Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36415

Stage is displayed as failed although it completed successfully after retrying

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • pipeline-stage-view-plugin
    • None
    • Jenkins 2.11
      pipeline-stage-view-plugin 1.5

      We have implemented a retry mechanism in our pipeline and if the step fails in the first run, it is retried and then succeeds, the stage is still shown as failed, but the build is green.

      See the attached screenshot. The second stage is shown as failed which was retried once.

      To reproduce:

      node {
    stage "1"
    stage "2"
    def counter = 0
    waitUntil {
        counter++
        try {
            if (counter == 1) {
                sh "false"
            }
            return true
        }
        catch (e) {
            return false
        }
    }
    stage "3"
}

        1. screenshot.png
          screenshot.png
          53 kB

          [JENKINS-36415] Stage is displayed as failed although it completed successfully after retrying

          Timo Ulich created issue -
          Timo Ulich made changes -
          Description Original: We have implemented a retry mechanism in our pipeline and if the step fails in the first run, then is retried and then succeeds, the stage is still shown as failed, but the build is green.

          See the attached screenshot. The second stage in Build #124 is shown as failed which was retried once.

          To reproduce:
          {code}
          node {
              stage "1"
              stage "2"
              def counter = 0
              waitUntil {
                  counter++
                  try {
                      if (counter == 1) {
                          sh "false"
                      }
                      return true
                  }
                  catch (e) {
                      return false
                  }
              }
              stage "3"
          }
          {code}

          		 New: We have implemented a retry mechanism in our pipeline and if the step fails in the first run, then is retried and then succeeds, the stage is still shown as failed, but the build is green.

          See the attached screenshot. The second stage is shown as failed which was retried once.

          To reproduce:
          {code}
          node {
              stage "1"
              stage "2"
              def counter = 0
              waitUntil {
                  counter++
                  try {
                      if (counter == 1) {
                          sh "false"
                      }
                      return true
                  }
                  catch (e) {
                      return false
                  }
              }
              stage "3"
          }
          {code}
          Timo Ulich made changes -
          Description Original: We have implemented a retry mechanism in our pipeline and if the step fails in the first run, then is retried and then succeeds, the stage is still shown as failed, but the build is green.

          See the attached screenshot. The second stage is shown as failed which was retried once.

          To reproduce:
          {code}
          node {
              stage "1"
              stage "2"
              def counter = 0
              waitUntil {
                  counter++
                  try {
                      if (counter == 1) {
                          sh "false"
                      }
                      return true
                  }
                  catch (e) {
                      return false
                  }
              }
              stage "3"
          }
          {code}

          		 New: We have implemented a retry mechanism in our pipeline and if the step fails in the first run, it is retried and then succeeds, the stage is still shown as failed, but the build is green.

          See the attached screenshot. The second stage is shown as failed which was retried once.

          To reproduce:
          {code}
          node {
              stage "1"
              stage "2"
              def counter = 0
              waitUntil {
                  counter++
                  try {
                      if (counter == 1) {
                          sh "false"
                      }
                      return true
                  }
                  catch (e) {
                      return false
                  }
              }
              stage "3"
          }
          {code}

          Sam Van Oort added a comment -

          Reproducing this on my own system, I've confirmed this caused by JENKINS-34212 - and the fix that I have prepared in https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/21 for that issue will also resolve it. You should have your fix next week when it's out of review and I've cut the release.

          Sam Van Oort added a comment - Reproducing this on my own system, I've confirmed this caused by JENKINS-34212 - and the fix that I have prepared in https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/21 for that issue will also resolve it. You should have your fix next week when it's out of review and I've cut the release.
          Sam Van Oort made changes -
          Link New: This issue duplicates JENKINS-34212 [ JENKINS-34212 ]
          Sam Van Oort made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 173121 ] New: JNJira + In-Review [ 210194 ]

            svanoort Sam Van Oort
            ulich Timo Ulich
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: