Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36419

git plugin 2.5.1 breaks multibranch pipeline if using github source control

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • git-plugin
    • None
    • Jenkins 1.651.3, ubuntu 14.04, Oracle Java 7

      Once I updated to 2.5.1, I couldn't index the branches anymore in my pipeline projects which use github as their source control rather than git. Going back to 2.5.0 makes it work again. It also works if I use the "git" section instead of the "github" section for source control.

      The exception in the log is

      Executor threw an exception
      java.lang.AbstractMethodError: jenkins.plugins.git.AbstractGitSCMSource.getExtensions()Ljava/util/List;
      	at jenkins.plugins.git.AbstractGitSCMSource.build(AbstractGitSCMSource.java:305)
      	at jenkins.scm.api.SCMSource.build(SCMSource.java:283)
      	at jenkins.branch.MultiBranchProject.newBranch(MultiBranchProject.java:267)
      	at jenkins.branch.MultiBranchProject.access$000(MultiBranchProject.java:82)
      	at jenkins.branch.MultiBranchProject$1.observe(MultiBranchProject.java:297)
      	at org.jenkinsci.plugins.github_branch_source.GitHubSCMSource.doRetrieve(GitHubSCMSource.java:285)
      	at org.jenkinsci.plugins.github_branch_source.GitHubSCMSource.retrieve(GitHubSCMSource.java:256)
      	at jenkins.scm.api.SCMSource.fetch(SCMSource.java:146)
      	at jenkins.branch.MultiBranchProject.computeChildren(MultiBranchProject.java:294)
      	at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:157)
      	at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:122)
      	at hudson.model.ResourceController.execute(ResourceController.java:98)
      	at hudson.model.Executor.run(Executor.java:410)
      

          [JENKINS-36419] git plugin 2.5.1 breaks multibranch pipeline if using github source control

          Mark Waite added a comment -

          oleg_nenashev I'm willing to revert the entire change from PR350 and release a new git plugin 2.5.2 rather than break compatibility for downstream consumers of the AbstractGitSCMSource interface.

          Mark Waite added a comment - oleg_nenashev I'm willing to revert the entire change from PR350 and release a new git plugin 2.5.2 rather than break compatibility for downstream consumers of the AbstractGitSCMSource interface.

          Oleg Nenashev added a comment -

          markewaite I'm working on a more graceful PR, but it's up to you

          Oleg Nenashev added a comment - markewaite I'm working on a more graceful PR, but it's up to you

          Oleg Nenashev added a comment -

          In my PR there won't be compatibility breakage. To be submitted in 20 minutes

          Oleg Nenashev added a comment - In my PR there won't be compatibility breakage. To be submitted in 20 minutes

          markewaite Thanks for updating the details about github/git source. I believe it's now rolling.

          Vlad Dumitrescu added a comment - markewaite Thanks for updating the details about github/git source. I believe it's now rolling.

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - https://github.com/jenkinsci/git-plugin/pull/420

          Oleg Nenashev added a comment -

          markewaite So the PR is under review

          Oleg Nenashev added a comment - markewaite So the PR is under review

          Mark Waite added a comment -

          oleg_nenashev yes, I've been running tests on the change for the last few hours using my Docker instance and multiple slaves. I specifically checked this problem is fixed and have been doing additional exploratory testing. I intend to release git plugin 2.5.2 before end of the day today so that it will be visible in the update center before U.S. users return from their independence day holiday tomorrow.

          Mark Waite added a comment - oleg_nenashev yes, I've been running tests on the change for the last few hours using my Docker instance and multiple slaves. I specifically checked this problem is fixed and have been doing additional exploratory testing. I intend to release git plugin 2.5.2 before end of the day today so that it will be visible in the update center before U.S. users return from their independence day holiday tomorrow.

          Mark Waite added a comment -

          Fix in git plugin 2.5.2 released 4 Jul 2016.

          Mark Waite added a comment - Fix in git plugin 2.5.2 released 4 Jul 2016.

          Excellent, thank you very much!

          Vlad Dumitrescu added a comment - Excellent, thank you very much!

          \o/ great job. Congratulations.

          Leandro Kersting de Freitas added a comment - \o/ great job. Congratulations.

            oleg_nenashev Oleg Nenashev
            vladdu Vlad Dumitrescu
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: