Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36432

Provide a SecretBytes type for space efficient local storage of an encrypted byte[]

    XMLWordPrintable

Details

    Attachments

      Issue Links

        links to

        Web Link PR 64

        Activity

          Descending order - Click to sort in ascending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java
          src/main/java/org/jenkinsci/plugins/plaincredentials/impl/StringCredentialsImpl.java
          src/main/resources/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl/credentials.jelly
          src/test/java/org/jenkinsci/plugins/plaincredentials/BaseTest.java
          src/test/java/org/jenkinsci/plugins/plaincredentials/FileCredentialsTest.java
          src/test/java/org/jenkinsci/plugins/plaincredentials/SecretBytesTest.java
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/config.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/credentials.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/config.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/credentials.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secret.key
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/master.key
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.main.modules.instance_identity.InstanceIdentity.KEY
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.plugins.plaincredentials.impl.FileCredentialsImpl
          http://jenkins-ci.org/commit/plain-credentials-plugin/c3cc4866bb5fd3b5e2894953f77e827ec85864b4
          Log:
          Merge pull request #6 from jenkinsci/jenkins-36432-followup

          [JENKINS-36432 followup] Switch to SecretBytes rather than home grown secret key

          Compare: https://github.com/jenkinsci/plain-credentials-plugin/compare/e682318047d7...c3cc4866bb5f

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java src/main/java/org/jenkinsci/plugins/plaincredentials/impl/StringCredentialsImpl.java src/main/resources/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl/credentials.jelly src/test/java/org/jenkinsci/plugins/plaincredentials/BaseTest.java src/test/java/org/jenkinsci/plugins/plaincredentials/FileCredentialsTest.java src/test/java/org/jenkinsci/plugins/plaincredentials/SecretBytesTest.java src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/config.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/credentials.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/config.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/credentials.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secret.key src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/master.key src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.main.modules.instance_identity.InstanceIdentity.KEY src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.plugins.plaincredentials.impl.FileCredentialsImpl http://jenkins-ci.org/commit/plain-credentials-plugin/c3cc4866bb5fd3b5e2894953f77e827ec85864b4 Log: Merge pull request #6 from jenkinsci/jenkins-36432-followup [JENKINS-36432 followup] Switch to SecretBytes rather than home grown secret key Compare: https://github.com/jenkinsci/plain-credentials-plugin/compare/e682318047d7...c3cc4866bb5f
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java
          src/test/java/org/jenkinsci/plugins/plaincredentials/SecretBytesTest.java
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/config.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/credentials.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/config.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/credentials.xml
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secret.key
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/master.key
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.main.modules.instance_identity.InstanceIdentity.KEY
          src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.plugins.plaincredentials.impl.FileCredentialsImpl
          http://jenkins-ci.org/commit/plain-credentials-plugin/ce212cc43c52b0f8a7c968855c23277e2657f520
          Log:
          [JENKINS-36432 followup] Add tests of migration and reading plain-text

          • The reading of plain-text from the on-disk XML is for e.g. people using chef/puppet scripts to pre-populate their JENKINS_HOME
          • The reading of plain-text from the CLI create credentials command is an obvious additional use case. This also applies to the REST API for credentials creation, but as the REST API is already tested in the credentials plugin I do not see any value in adding a specific test for that scenario.
          • The migration of legacy data intact is also an obvious requirement
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java src/test/java/org/jenkinsci/plugins/plaincredentials/SecretBytesTest.java src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/config.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/loadUnencrypted/credentials.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/config.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/credentials.xml src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secret.key src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/master.key src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.main.modules.instance_identity.InstanceIdentity.KEY src/test/resources/org/jenkinsci/plugins/plaincredentials/SecretBytesTest/migrateLegacyData/secrets/org.jenkinsci.plugins.plaincredentials.impl.FileCredentialsImpl http://jenkins-ci.org/commit/plain-credentials-plugin/ce212cc43c52b0f8a7c968855c23277e2657f520 Log: [JENKINS-36432 followup] Add tests of migration and reading plain-text The reading of plain-text from the on-disk XML is for e.g. people using chef/puppet scripts to pre-populate their JENKINS_HOME The reading of plain-text from the CLI create credentials command is an obvious additional use case. This also applies to the REST API for credentials creation, but as the REST API is already tested in the credentials plugin I do not see any value in adding a specific test for that scenario. The migration of legacy data intact is also an obvious requirement
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java
          http://jenkins-ci.org/commit/plain-credentials-plugin/505f4e4ca6cd7fc69cb5ad0ca16499c8bf390f96
          Log:
          [JENKINS-36432 followup] Address some review comments

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java http://jenkins-ci.org/commit/plain-credentials-plugin/505f4e4ca6cd7fc69cb5ad0ca16499c8bf390f96 Log: [JENKINS-36432 followup] Address some review comments
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java
          src/main/resources/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl/credentials.jelly
          src/test/java/org/jenkinsci/plugins/plaincredentials/BaseTest.java
          src/test/java/org/jenkinsci/plugins/plaincredentials/FileCredentialsTest.java
          http://jenkins-ci.org/commit/plain-credentials-plugin/64a83e59c59d77861d6b4ed99d4a38b593fc160c
          Log:
          [JENKINS-36432 followup] Switch to SecretBytes for storing the file content

          Compare: https://github.com/jenkinsci/plain-credentials-plugin/compare/aefd4bd42392^...64a83e59c59d

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java src/main/resources/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl/credentials.jelly src/test/java/org/jenkinsci/plugins/plaincredentials/BaseTest.java src/test/java/org/jenkinsci/plugins/plaincredentials/FileCredentialsTest.java http://jenkins-ci.org/commit/plain-credentials-plugin/64a83e59c59d77861d6b4ed99d4a38b593fc160c Log: [JENKINS-36432 followup] Switch to SecretBytes for storing the file content Compare: https://github.com/jenkinsci/plain-credentials-plugin/compare/aefd4bd42392 ^...64a83e59c59d
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/plain-credentials-plugin/aefd4bd42392d80de198feaa972b57a63c89f940
          Log:
          [JENKINS-36432 followup] Upgrade dependencies and reformat pom

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/plain-credentials-plugin/aefd4bd42392d80de198feaa972b57a63c89f940 Log: [JENKINS-36432 followup] Upgrade dependencies and reformat pom
          stephenconnolly Stephen Connolly added a comment -

          merged

          stephenconnolly Stephen Connolly added a comment - merged

          People

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: