Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36593

ItemCategory exposes public static MIN_TOSHOW field to API

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      In https://github.com/jenkinsci/jenkins/commit/25f9c99d8376667b2efaabe8cb6f5b4be6024618 recena introduced a new "public static int MIN_TOSHOW = 1" field. So we have a constant, which can be occasionally modified by any API user.

      This field is now a part of API, so we cannot easily convert it to final or make private. My proposal is to restrict it at least

          [JENKINS-36593] ItemCategory exposes public static MIN_TOSHOW field to API

          Oleg Nenashev created issue -
          Manuel Recena Soto made changes -
          Remote Link New: This issue links to "PR-2449 (Web Link)" [ 14609 ]
          Manuel Recena Soto made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Manuel Recena Soto made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]

          oleg_nenashev I sent my comments to the PR.

          Manuel Recena Soto added a comment - oleg_nenashev I sent my comments to the PR.

          Daniel Beck added a comment -

          Fixed in 2.14 (2016/07/17)

          Daniel Beck added a comment - Fixed in 2.14 (2016/07/17)
          Daniel Beck made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Daniel Beck made changes -
          Labels New: lts-candidate

          Daniel Beck added a comment -

          olivergondza Should be expedited into 2.7.2 to prevent people from using it IMO.

          Daniel Beck added a comment - olivergondza Should be expedited into 2.7.2 to prevent people from using it IMO.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 173314 ] New: JNJira + In-Review [ 199432 ]

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: