Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37026

404 error when clicking a link to the attachment which includes '%' character

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • None
    • * Jenkins: 2.7.1
      * JUnit Attachments Plugin: 1.4.2
      * JUnit: 4.8.1

    Attachments

      Issue Links

        Activity

          Unfortunately, this change breaks links to files with spaces in their name (But AFAICS the new format is the correct way to encode spaces in URLs).

          This plugin creates: href="attachments/Report+hold.png"

          Jenkins Core seems to expect URLs to contain the space as %20 for example, the workspace/attachement browser encodes them correctly...

          tgr Tobias Gruetzmacher added a comment - Unfortunately, this change breaks links to files with spaces in their name (But AFAICS the new format is the correct way to encode spaces in URLs). This plugin creates: href="attachments/Report+hold.png" Jenkins Core seems to expect URLs to contain the space as %20 for example, the workspace/attachement browser encodes them correctly...

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java
          src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly
          http://jenkins-ci.org/commit/junit-attachments-plugin/579bba59885f38ba85a0bb571037cd1bed188f1d
          Log:
          Merge pull request #16 from miyajan/JENKINS-37026

          JENKINS-37026 Fix to encode URL to attachments

          Compare: https://github.com/jenkinsci/junit-attachments-plugin/compare/5914e4a5f022...579bba59885f

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly http://jenkins-ci.org/commit/junit-attachments-plugin/579bba59885f38ba85a0bb571037cd1bed188f1d Log: Merge pull request #16 from miyajan/ JENKINS-37026 JENKINS-37026 Fix to encode URL to attachments Compare: https://github.com/jenkinsci/junit-attachments-plugin/compare/5914e4a5f022...579bba59885f

          Code changed in jenkins
          User: jumpei-miyata
          Path:
          src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java
          src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly
          http://jenkins-ci.org/commit/junit-attachments-plugin/a6341ac8d5812eb7dfcf03e8c7f5ea2e33b6883d
          Log:
          JENKINS-37026 Fix to encode URL to attachments

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: jumpei-miyata Path: src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly http://jenkins-ci.org/commit/junit-attachments-plugin/a6341ac8d5812eb7dfcf03e8c7f5ea2e33b6883d Log: JENKINS-37026 Fix to encode URL to attachments

          People

            miyajan Miyata Jumpei
            miyajan Miyata Jumpei
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: