Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37539

Potential NPE in the remoting Engine#connect() if null host or port gets passed

    XMLWordPrintable

    Details

    • Similar Issues:

      Attachments

        Activity

        Ascending order - Click to sort in descending order
        oleg_nenashev Oleg Nenashev created issue -
        oleg_nenashev Oleg Nenashev made changes -
        Field Original Value New Value
        Assignee Oleg Nenashev [ oleg_nenashev ]
        oleg_nenashev Oleg Nenashev made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Permalink
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Oleg Nenashev
        Path:
        src/main/java/hudson/remoting/Engine.java
        src/main/java/hudson/remoting/Util.java
        http://jenkins-ci.org/commit/remoting/98107a2ce50e750af48a703b4faf232288e8a859
        Log:
        [FIXED JENKINS-37539] - Prevent NPE in Engine#connect() when host or port are null or empty (#101)

        Bug diagnosis:

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/Util.java http://jenkins-ci.org/commit/remoting/98107a2ce50e750af48a703b4faf232288e8a859 Log: [FIXED JENKINS-37539] - Prevent NPE in Engine#connect() when host or port are null or empty (#101) Bug diagnosis: https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836372&defectInstanceId=4427367&mergedDefectId=152195 https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836372&defectInstanceId=4427365&mergedDefectId=152194
        scm_issue_link SCM/JIRA link daemon made changes -
        Resolution Fixed [ 1 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Hide
        Permalink
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Oleg Nenashev
        Path:
        src/main/java/hudson/remoting/Engine.java
        src/main/java/hudson/remoting/Util.java
        src/main/java/hudson/remoting/jnlp/Main.java
        src/main/java/org/jenkinsci/remoting/engine/EngineUtil.java
        src/main/java/org/jenkinsci/remoting/engine/JnlpAgentEndpointResolver.java
        http://jenkins-ci.org/commit/remoting/190653b3a3e7a9b582cf923201c735d6d3043ea2
        Log:
        Merge stable-2.x into master (#107)

        • [maven-release-plugin] prepare release remoting-2.62
        • [maven-release-plugin] prepare for next development iteration
        • [FIXED JENKINS-37539] - Prevent NPE in Engine#connect() when host or port are null or empty (#101)

        Bug diagnosis:

        • [CID-152201] - Fix resource leak in remoting.jnlp.Main (#102)
        • [CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths (#104)
        • [CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths
        • [CID-152202] - Fix typo noticed by @olivergondza
        • Fix another merge conflict
        • Remove EngineUtil#closeAndLogFailures()
        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/Util.java src/main/java/hudson/remoting/jnlp/Main.java src/main/java/org/jenkinsci/remoting/engine/EngineUtil.java src/main/java/org/jenkinsci/remoting/engine/JnlpAgentEndpointResolver.java http://jenkins-ci.org/commit/remoting/190653b3a3e7a9b582cf923201c735d6d3043ea2 Log: Merge stable-2.x into master (#107) [maven-release-plugin] prepare release remoting-2.62 [maven-release-plugin] prepare for next development iteration [FIXED JENKINS-37539] - Prevent NPE in Engine#connect() when host or port are null or empty (#101) Bug diagnosis: https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836372&defectInstanceId=4427367&mergedDefectId=152195 https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836372&defectInstanceId=4427365&mergedDefectId=152194 [CID-152201] - Fix resource leak in remoting.jnlp.Main (#102) [CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths (#104) [CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836377&defectInstanceId=4427377&mergedDefectId=152202 https://scan8.coverity.com/reports.htm#v14462/p10499/fileInstanceId=12836377&defectInstanceId=4427377&mergedDefectId=152200 [CID-152202] - Fix typo noticed by @olivergondza Fix another merge conflict Remove EngineUtil#closeAndLogFailures()
        Hide
        Permalink
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Oleg Nenashev
        Path:
        pom.xml
        http://jenkins-ci.org/commit/jenkins/3966b111f9f2f87d39854aefe870676fdd5cc4ae
        Log:
        [JENKINS-38539, JENKINS-37539] Update remoting from 2.62 to 2.62.2

        2.61 does not exist, there was an issue during the release
        Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/3966b111f9f2f87d39854aefe870676fdd5cc4ae Log: [JENKINS-38539, JENKINS-37539] Update remoting from 2.62 to 2.62.2 2.61 does not exist, there was an issue during the release Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622 JENKINS-38539 ( https://issues.jenkins-ci.org/browse/JENKINS-38539 ) - Stability: Turn on SO_KEEPALIVE and provide CLI option to turn it off again. ( https://github.com/jenkinsci/remoting/pull/110 ) JENKINS-37539 ( https://issues.jenkins-ci.org/browse/JENKINS-37539 ) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. ( https://github.com/jenkinsci/remoting/pull/101 ) [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. ( https://github.com/jenkinsci/remoting/pull/102 ) [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. ( https://github.com/jenkinsci/remoting/pull/104 )
        Hide
        Permalink
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Oleg Nenashev
        Path:
        pom.xml
        http://jenkins-ci.org/commit/jenkins/7e0db20a2cfb08b49e32cf2ec8258ef3f4b3037e
        Log:
        [JENKINS-38539, JENKINS-37539] Update remoting from 2.62 to 2.62.2 (#2585)

        2.61 does not exist, there was an issue during the release
        Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/7e0db20a2cfb08b49e32cf2ec8258ef3f4b3037e Log: [JENKINS-38539, JENKINS-37539] Update remoting from 2.62 to 2.62.2 (#2585) 2.61 does not exist, there was an issue during the release Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622 JENKINS-38539 ( https://issues.jenkins-ci.org/browse/JENKINS-38539 ) - Stability: Turn on SO_KEEPALIVE and provide CLI option to turn it off again. ( https://github.com/jenkinsci/remoting/pull/110 ) JENKINS-37539 ( https://issues.jenkins-ci.org/browse/JENKINS-37539 ) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. ( https://github.com/jenkinsci/remoting/pull/101 ) [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. ( https://github.com/jenkinsci/remoting/pull/102 ) [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. ( https://github.com/jenkinsci/remoting/pull/104 )
        Hide
        Permalink
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Oleg Nenashev
        Path:
        pom.xml
        http://jenkins-ci.org/commit/jenkins/62a5dddb3c2b00c4602a504ffefd65320cf81915
        Log:
        Update remoting to 2.62.2

        This PR picks the latest available version of remoting stable-2.x. All the fixes have been integrated into remoting-3.0 and soaked enough.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/62a5dddb3c2b00c4602a504ffefd65320cf81915 Log: Update remoting to 2.62.2 This PR picks the latest available version of remoting stable-2.x. All the fixes have been integrated into remoting-3.0 and soaked enough. JENKINS-38539 ( https://issues.jenkins-ci.org/browse/JENKINS-38539 ) - Stability: Turn on SO_KEEPALIVE by default and provide CLI option to turn it off again. ( https://github.com/jenkinsci/remoting/pull/110 ) JENKINS-37539 ( https://issues.jenkins-ci.org/browse/JENKINS-37539 ) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. ( https://github.com/jenkinsci/remoting/pull/101 ) [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. ( https://github.com/jenkinsci/remoting/pull/102 ) [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. ( https://github.com/jenkinsci/remoting/pull/104 )
        oleg_nenashev Oleg Nenashev made changes -
        Labels 2.19.3-fixed
        olivergondza Oliver Gondža made changes -
        Labels 2.19.3-fixed 2.19.4-fixed

          People

          Assignee:
          oleg_nenashev Oleg Nenashev
          Reporter:
          oleg_nenashev Oleg Nenashev
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: