Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38170

Manual approval is stored, even if requirements are not matched

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • promoted-builds-plugin
    • None
    • Jenkins 2.21 on Linux x86-64
      Promoted Builds Plugin 2.27

      I want to establish a QA pipe like described in the documentation of the plugin.

      Therefor, I have the following promotion steps:

      DeployStaging

      • only when manually approved

      TestedOnStaging

      • only when manually approved
      • when upstream promotions promoted: DeployStaging

      DeployProduction

      • only when manually approved
      • when upstream promotions promoted: TestedOnStaging

      So my intention is that first some has to trigger the deployment on the staging server, then it has to be tested and only if that was approved, it can be deployed to the production server.

      Now when no step was every promoted and I trigger DeployProduction, it correctly tells me "Unmet qualification: TestedOnStaging".

      Then I trigger TestedOnStaging and it correctly tells me that DeployStaging qualification was not met.

      But if I now trigger DeployStaging, it deploys, automatically triggers TestedOnStaging and then automatically triggers DeployProduction.

      Is this behavior intended? As I cannot undo a manually promotion, I think that the behavior is very risky and may force unintended behavior.

          [JENKINS-38170] Manual approval is stored, even if requirements are not matched

          Tammy Osborn added a comment -

          I agree that this is a critical bug. We need a way to remove manual approval so that the downstream promotion doesn't immediately happen when upstream promotions are done. Or we need to prevent any manual approvals if other criteria is not met yet.

          Tammy Osborn added a comment - I agree that this is a critical bug. We need a way to remove manual approval so that the downstream promotion doesn't immediately happen when upstream promotions are done. Or we need to prevent any manual approvals if other criteria is not met yet.

          Oleg Nenashev added a comment -

          Sorry, over last months I had no time to work on the plugin, because I had to focus on the Jenkins core and other projects. I also have not been using this plugin on my own since 2016. So I have decided to unassign the issues so that there is no expectation that I work on them anytime soon.

          Currently the plugin is being transfered to another maintainer. Hopefully he will have some time to finish triaging of the issues and maybe to deliver some fixes. But, as in any community-driven project, everybody is welcome to propose pull requests and to contribute to the plugin's state.

          Oleg Nenashev added a comment - Sorry, over last months I had no time to work on the plugin, because I had to focus on the Jenkins core and other projects. I also have not been using this plugin on my own since 2016. So I have decided to unassign the issues so that there is no expectation that I work on them anytime soon. Currently the plugin is being transfered to another maintainer. Hopefully he will have some time to finish triaging of the issues and maybe to deliver some fixes. But, as in any community-driven project, everybody is welcome to propose pull requests and to contribute to the plugin's state.

            Unassigned Unassigned
            maxzilla Max Wahler
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: