Details
-
Improvement
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
Currently a generator has to be set. Clearing the field will reset it to a default (‘Unix Makefiles’).
CMake doesn’t require a generator to be specified. Without it it will simply choose one of the generators available (so it will be different on different platforms).
I suggest allowing to leave the generator field empty, and that this will result in no -G option being passed to cmake. This will allow multi-slave builds to work across different platforms. (Something I am currently trying to set up, but which fails since there’s no generator I could choose that would work on all the targeted platforms.)
(I’d be willing to implement this and send a pull request.)
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Assignee | Martin Weber [ 15knots ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Closed [ 6 ] |
Code changed in jenkins
User: 15knots
Path:
.project
src/main/java/hudson/plugins/cmake/CmakeBuilder.java
src/main/resources/hudson/plugins/cmake/CmakeBuilder/config.jelly
src/main/resources/hudson/plugins/cmake/CmakeBuilder/help-generator.html
src/test/java/hudson/plugins/cmake/CmakeBuilderTest.java
http://jenkins-ci.org/commit/cmakebuilder-plugin/cfa73debff9f0706e9b20b40b906788795ff79ed
Log:
Progress on
JENKINS-38227Compare: https://github.com/jenkinsci/cmakebuilder-plugin/compare/c0d6b8243d7d...cfa73debff9f