Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38607

Wrong parsing of 'property content' drops backslash from string

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not A Defect
    • Icon: Blocker Blocker
    • envinject-plugin
    • None
    • env inject 1.93
      jenkins 2.23

      Steps to reproduce : inject env var using 'envInject' plugin with content :

      JENKINS_TOOLS=E:\JenkinsTools

      (check on screenshot)

      Then call this var in a step 'execute shell script', you'll see that \ char has been dropped.
      This is a regression in this version : rollback to 1.92.1 restores the right behavior.

      Could be caused by resolution of : https://issues.jenkins-ci.org/browse/JENKINS-31573 ?

      Thx

        1. 2016-09-29_1635.png
          2016-09-29_1635.png
          9 kB

          [JENKINS-38607] Wrong parsing of 'property content' drops backslash from string

          Oleg Nenashev added a comment -

          Yes, it's caused by the resolution of JENKINS-31573.
          But the new behavior complies with https://en.wikipedia.org/wiki/.properties#Format instead of the original one, so I do not consider it as a bug. Wiki explicitly mentions this potential compatibility issue.

          But I definitely should update the data in update center in order to notice users about such compatibility change

          Oleg Nenashev added a comment - Yes, it's caused by the resolution of JENKINS-31573 . But the new behavior complies with https://en.wikipedia.org/wiki/.properties#Format instead of the original one, so I do not consider it as a bug. Wiki explicitly mentions this potential compatibility issue. But I definitely should update the data in update center in order to notice users about such compatibility change

          Alexandre Aubert added a comment -

          thanks for this information, i updated my setup to match the 'standard' of properties files and it's fine with the new version of the plugin (1.93).

          Keeping the bug opened until information of 'no backward compatibility' have been published, if you agree with that.
          Otherwise, letting you close the bug.

          Thx

          Alexandre Aubert added a comment - thanks for this information, i updated my setup to match the 'standard' of properties files and it's fine with the new version of the plugin (1.93). Keeping the bug opened until information of 'no backward compatibility' have been published, if you agree with that. Otherwise, letting you close the bug. Thx

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-plugin/980150dd4dd931751155995be76416faa4201ce2
          Log:
          [FIXED JENKINS-38607] - Add explicit compatibility notice for the JENKINS-31573 change

          Also updates maven-hpi-version to the version declared in POM

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-plugin/980150dd4dd931751155995be76416faa4201ce2 Log: [FIXED JENKINS-38607] - Add explicit compatibility notice for the JENKINS-31573 change Also updates maven-hpi-version to the version declared in POM

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/resources/index.jelly
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectBuilder/config.jelly
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/config.jelly
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/global.jelly
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper/config.jelly
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectVarList/index.jelly
          http://jenkins-ci.org/commit/envinject-plugin/df2515692aa050cfda1ece0ffdbc5c7cb5487c8e
          Log:
          Merge pull request #108 from oleg-nenashev/bug/JENKINS-38607

          [FIXED JENKINS-38607] - Add explicit compatibility notice for the JENKINS-31573 change

          Compare: https://github.com/jenkinsci/envinject-plugin/compare/8aec81f23148...df2515692aa0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/resources/index.jelly src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectBuilder/config.jelly src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/config.jelly src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/global.jelly src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper/config.jelly src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectVarList/index.jelly http://jenkins-ci.org/commit/envinject-plugin/df2515692aa050cfda1ece0ffdbc5c7cb5487c8e Log: Merge pull request #108 from oleg-nenashev/bug/ JENKINS-38607 [FIXED JENKINS-38607] - Add explicit compatibility notice for the JENKINS-31573 change Compare: https://github.com/jenkinsci/envinject-plugin/compare/8aec81f23148...df2515692aa0

          Oleg Nenashev added a comment -

          Added the notice.
          It should be released in 1.93.1 today

          Oleg Nenashev added a comment - Added the notice. It should be released in 1.93.1 today

            oleg_nenashev Oleg Nenashev
            splashnenen Alexandre Aubert
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: