Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38960

Deprecate TopLevelItemDescriptor.getIconFilePathPattern() and TopLevelItemDescriptor.getIconFile(String)

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      These two methods were introduced in Jenkins 2.0

      Given that IconSet and IconSpec have been available since August 2014, the Icon classes should actually have been used instead of hardcoding a path.

          [JENKINS-38960] Deprecate TopLevelItemDescriptor.getIconFilePathPattern() and TopLevelItemDescriptor.getIconFile(String)

          Stephen Connolly created issue -
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Stephen Connolly made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/folder.svg
          src/images/make-inkscape.sh
          src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
          src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java
          src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly
          src/main/webapp/images/16x16/folder.png
          src/main/webapp/images/24x24/folder.png
          src/main/webapp/images/32x32/folder.png
          src/main/webapp/images/48x48/folder.png
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/5dfa20ed76a05b59120939e2b958f332d5862c16
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/folder.svg src/images/make-inkscape.sh src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly src/main/webapp/images/16x16/folder.png src/main/webapp/images/24x24/folder.png src/main/webapp/images/32x32/folder.png src/main/webapp/images/48x48/folder.png http://jenkins-ci.org/commit/cloudbees-folder-plugin/5dfa20ed76a05b59120939e2b958f332d5862c16 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/webapp/images/48x48/github-scmnavigator.png
          http://jenkins-ci.org/commit/github-branch-source-plugin/c94b4f076ebfde87b6793487d69dea1fecd8347d
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/webapp/images/48x48/github-scmnavigator.png http://jenkins-ci.org/commit/github-branch-source-plugin/c94b4f076ebfde87b6793487d69dea1fecd8347d Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
          http://jenkins-ci.org/commit/branch-api-plugin/648edd2b35925f9a491d3b35fc0ce92485304271
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java http://jenkins-ci.org/commit/branch-api-plugin/648edd2b35925f9a491d3b35fc0ce92485304271 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/github-scmnavigator.svg
          src/images/make-inkscape.sh
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/webapp/images/16x16/github-scmnavigator.png
          src/main/webapp/images/24x24/github-scmnavigator.png
          src/main/webapp/images/32x32/github-scmnavigator.png
          src/main/webapp/images/48x48/github-scmnavigator.png
          http://jenkins-ci.org/commit/github-branch-source-plugin/f14427b130c465bd43e9af76be9c47050e3c6ce3
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/github-scmnavigator.svg src/images/make-inkscape.sh src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/webapp/images/16x16/github-scmnavigator.png src/main/webapp/images/24x24/github-scmnavigator.png src/main/webapp/images/32x32/github-scmnavigator.png src/main/webapp/images/48x48/github-scmnavigator.png http://jenkins-ci.org/commit/github-branch-source-plugin/f14427b130c465bd43e9af76be9c47050e3c6ce3 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/branch-api-plugin/66823d0c6bc1a04cc3087a60ec88fe454fed20a8
          Log:
          [JENKINS-38960 Follow-up] Need latest scm-api

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/branch-api-plugin/66823d0c6bc1a04cc3087a60ec88fe454fed20a8 Log: [JENKINS-38960 Follow-up] Need latest scm-api

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
          http://jenkins-ci.org/commit/branch-api-plugin/3645881cb775782935b6048bb322bc63c520813b
          Log:
          Merge pull request #51 from jenkinsci/use-iconset

          [JENKINS-38960 Follow-up] Switch to IconSet

          Compare: https://github.com/jenkinsci/branch-api-plugin/compare/637eeced2a9a...3645881cb775

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java http://jenkins-ci.org/commit/branch-api-plugin/3645881cb775782935b6048bb322bc63c520813b Log: Merge pull request #51 from jenkinsci/use-iconset [JENKINS-38960 Follow-up] Switch to IconSet Compare: https://github.com/jenkinsci/branch-api-plugin/compare/637eeced2a9a...3645881cb775

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/folder.svg
          src/images/make-inkscape.sh
          src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
          src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java
          src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly
          src/main/webapp/images/16x16/folder.png
          src/main/webapp/images/24x24/folder.png
          src/main/webapp/images/32x32/folder.png
          src/main/webapp/images/48x48/folder.png
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/fc2cff09dfc0282a9d83fc5d0f68d1ba872cd88f
          Log:
          Merge pull request #71 from jenkinsci/use-iconset

          [JENKINS-38960 Follow-up] Switch to IconSet

          Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ac5476606a67...fc2cff09dfc0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/folder.svg src/images/make-inkscape.sh src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly src/main/webapp/images/16x16/folder.png src/main/webapp/images/24x24/folder.png src/main/webapp/images/32x32/folder.png src/main/webapp/images/48x48/folder.png http://jenkins-ci.org/commit/cloudbees-folder-plugin/fc2cff09dfc0282a9d83fc5d0f68d1ba872cd88f Log: Merge pull request #71 from jenkinsci/use-iconset [JENKINS-38960 Follow-up] Switch to IconSet Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ac5476606a67...fc2cff09dfc0

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: