Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Fixed
Description
Spin-off of JENKINS-16490. In Jenkins project we use this library for managing Windows Agents/Slaves. It's being done by launching a slave.jar via Java. Since the remoting library (effectively slave.jar) is being updated frequently, we would like to have an option to download it from the Jenkins instance directly.
For such purpose I propose to implement a WinSW plugin
Attachments
Issue Links
- is related to
-
JENKINS-16490 New versions of Remoting should be automatically pushed to Java Web Start agents
-
- Open
-
- links to
Activity
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java
src/main/resources/org/jenkinsci/modules/windows_slave_installer/jenkins-slave.xml
src/test/java/org/jenkinsci/modules/windows_slave_installer/MockLaunchConfiguration.java
src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java
http://jenkins-ci.org/commit/windows-slave-installer-module/33bf7bb673a70fb8b5c63ac35ba6229e88ee6aa8
Log:
JENKINS-39237 - Enable the automatic agent download during Windows Service Setup (#6)
JENKINS-39237- Enable the automatic agent download during Windows Service Setup
This change enables download of slave.jar on startup when it is possible.
WindowsSlaveInstaller internal API has been slightly tweaked for testing purposes.
JENKINS-39237- Fix FindBugs
JENKINS-39237- Disable the download by default
JENKINS-39237- Enable download for HTTPS only
Code changed in jenkins
User: Oleg Nenashev
Path:
core/pom.xml
core/src/main/resources/windows-service/jenkins-slave.xml
core/src/main/resources/windows-service/jenkins.xml
war/pom.xml
http://jenkins-ci.org/commit/jenkins/e698d1de41d4311bf5f8b1d2c40b591109e696e2
Log:
Update Windows Agent Installer to 1.7 and WinSW to 2.0.2 (#2765)
-
-
- WinSW changes
-
The update includes many fixes and improvements, the full list is provided in the [WinSW changelog](https://github.com/kohsuke/winsw/blob/master/CHANGELOG.md). There are several issues referenced in Jenkins bugtracker:
JENKINS-22692(https://issues.jenkins-ci.org/browse/JENKINS-22692) - Connection reset issues when WinSW gets terminated due to the system shutdownJENKINS-23487(https://issues.jenkins-ci.org/browse/JENKINS-23487)- Support of shared directories in WinSWJENKINS-39231(https://issues.jenkins-ci.org/browse/JENKINS-39231) - Enable Runaway Process Killer by defaultJENKINS-39237(https://issues.jenkins-ci.org/browse/JENKINS-39237) - Auto-upgrade of JNLP agent versions on the slaves
-
-
- Windows Agent Installer changes
-
- Adapt the default configurations to pick fixes above
- Slave => Agent renaming where possible
-
-
- Jenkins core changes
-
- Modify the configuration template, reference advanced options
- Enable Runaway Process Killer by default
- Update Windows Agent Installer to 1.7
- Remove the obsolete jenkins-slave.xml file from the core.
Now it is within windows-slave-installer
- Use the deployed Snapshot for CI
- Pick the release version of windows-slave-installer-1.7
The feature has been released in Jenkins 2.50
Automatic upgrade is enabled for newly installed agents with HTTPS connection.
See the upgrade guidelines here: https://github.com/jenkinsci/windows-slave-installer-module/blob/master/CHANGELOG.md#17
As a maintainer, I reject backporting of the fix to 2.46.3. The feature will be likely available in the next LTS baseline (to be elected on May 24)
casz, there is no need to. The fix went into 2.50 so it will be part of 2.60.1 released in 2 weeks anyway.
Created the pull request: https://github.com/jenkinsci/windows-slave-installer-module/pull/6
Will appreciate some testing and reviews