Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39300

View.getDisplayName() is ignored when rendering tabs

      The View.getDisplayName() is used when rendering the breadcrumb but not in the tabs. Thus a view that wants to use a localizable display name becomes confusing to users. For example in the attached screenshot:

      Here is a custom view with a view name of s that has overridden getDisplayName() to return a custom name asdjkls. The URL of the page is /view/s/, the breadcrumb bar shows asdjkls but the tab bar title is incorrectly showing as s

          [JENKINS-39300] View.getDisplayName() is ignored when rendering tabs

          Stephen Connolly created issue -
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Stephen Connolly made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Stephen Connolly made changes -
          Remote Link New: This issue links to "PR#2603 (Web Link)" [ 15001 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-38606 [ JENKINS-38606 ]

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/resources/hudson/views/DefaultMyViewsTabBar/myViewTabs.jelly
          core/src/main/resources/hudson/views/DefaultViewsTabBar/viewTabs.jelly
          core/src/main/resources/lib/layout/tab.jelly
          http://jenkins-ci.org/commit/jenkins/0763ffd0e928eeb7b2411701f03a165139902f54
          Log:
          [FIXED JENKINS-39300] Use View.getDisplayName() when rendering the view tabs

          • Also fix the stapler documentation for the <l:tab> tag

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/resources/hudson/views/DefaultMyViewsTabBar/myViewTabs.jelly core/src/main/resources/hudson/views/DefaultViewsTabBar/viewTabs.jelly core/src/main/resources/lib/layout/tab.jelly http://jenkins-ci.org/commit/jenkins/0763ffd0e928eeb7b2411701f03a165139902f54 Log: [FIXED JENKINS-39300] Use View.getDisplayName() when rendering the view tabs Also fix the stapler documentation for the <l:tab> tag
          Ryan Campbell made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

          Oleg Nenashev added a comment -

          Released in jenkins-2.37, marking as LTS candidate

          Oleg Nenashev added a comment - Released in jenkins-2.37, marking as LTS candidate
          Oleg Nenashev made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 2.32.2-rejected

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: