Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39355

API improvements based on real-world implementation and usage

    XMLWordPrintable

Details

    Description

      Various API improvements that make it easier to implement/consume SCM API:

      • Provide a way to perform probes without doing a full scan
      • Provide a way to allow scanning with custom criteria
      • Tweak the contract of SCMFileSystem to make it easier to implement/consume while reducing round trips
      • Clarify the difference between the SCMFileSystem view and the probe view.
      • Add categorization of SCMSource / SCMHead so that e.g. the Branch API can sort based on categories

      Attachments

        Issue Links

          is blocking

          Task - A task that needs to be done. JENKINS-40299 Adapt to the new SCM API for detecting change requests

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-33273 Optimize Jenkinsfile loading and branch detection

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Task - A task that needs to be done. JENKINS-42080 API to write a single file to the repository

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. JENKINS-39703 API to read a single file from the repository

          • Major - Major loss of function.
          • Closed
          links to

          Web Link CloudBees Internal OSS-1598

          Activity

            Ascending order - Click to sort in descending order
            View 31 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
            src/main/java/jenkins/plugins/git/GitSCMFile.java
            src/main/java/jenkins/plugins/git/GitSCMFileSystem.java
            src/main/java/jenkins/plugins/git/GitSCMSource.java
            src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java
            src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java
            src/test/java/jenkins/plugins/git/GitSCMSourceTest.java
            src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
            http://jenkins-ci.org/commit/git-plugin/63a092f8e5b3b40b7e99cd290393027312608466
            Log:
            Merge pull request #455 from jenkinsci/jenkins-39355-follow-up-3.x

            master branch [JENKINS-39355 follow up]JENKINS-40382 Pick up SCM API 2.x

            Compare: https://github.com/jenkinsci/git-plugin/compare/37a95884ac78...63a092f8e5b3

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMFile.java src/main/java/jenkins/plugins/git/GitSCMFileSystem.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTest.java src/test/java/jenkins/plugins/git/GitSampleRepoRule.java http://jenkins-ci.org/commit/git-plugin/63a092f8e5b3b40b7e99cd290393027312608466 Log: Merge pull request #455 from jenkinsci/jenkins-39355-follow-up-3.x master branch [JENKINS-39355 follow up] JENKINS-40382 Pick up SCM API 2.x Compare: https://github.com/jenkinsci/git-plugin/compare/37a95884ac78...63a092f8e5b3
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
            src/main/java/jenkins/plugins/git/GitSCMFile.java
            src/main/java/jenkins/plugins/git/GitSCMFileSystem.java
            src/main/java/jenkins/plugins/git/GitSCMSource.java
            src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java
            src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java
            src/test/java/jenkins/plugins/git/GitSCMSourceTest.java
            src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
            http://jenkins-ci.org/commit/git-plugin/3002ad11b13183d3118ec68cc1738206e3088808
            Log:
            Merge pull request #454 from jenkinsci/jenkins-39355-follow-up

            2.6.x branch [JENKINS-39355 follow up]JENKINS-40382 Pick up SCM API 2.x

            Compare: https://github.com/jenkinsci/git-plugin/compare/d9e1f8151cdc...3002ad11b131

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMFile.java src/main/java/jenkins/plugins/git/GitSCMFileSystem.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTest.java src/test/java/jenkins/plugins/git/GitSampleRepoRule.java http://jenkins-ci.org/commit/git-plugin/3002ad11b13183d3118ec68cc1738206e3088808 Log: Merge pull request #454 from jenkinsci/jenkins-39355-follow-up 2.6.x branch [JENKINS-39355 follow up] JENKINS-40382 Pick up SCM API 2.x Compare: https://github.com/jenkinsci/git-plugin/compare/d9e1f8151cdc...3002ad11b131
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
            http://jenkins-ci.org/commit/mercurial-plugin/8ef4e51f1d78483478c27ed5692522742869da2d
            Log:
            [JENKINS-39355 Follow-up] Also adding an attempt at a probe

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/8ef4e51f1d78483478c27ed5692522742869da2d Log: [JENKINS-39355 Follow-up] Also adding an attempt at a probe
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/hudson/plugins/mercurial/MercurialCommitPayload.java
            src/main/java/hudson/plugins/mercurial/MercurialSCMHeadEvent.java
            src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
            src/main/java/hudson/plugins/mercurial/MercurialStatus.java
            src/main/java/hudson/plugins/mercurial/MercurialStatusCrumbExclusion.java
            src/test/java/hudson/plugins/mercurial/MercurialSampleRepoRule.java
            src/test/java/hudson/plugins/mercurial/PipelineTest.java
            http://jenkins-ci.org/commit/mercurial-plugin/d0f8f4b930b96fd2da53ae50b0037163eb09ae48
            Log:
            [JENKINS-39355 Follow-up] Adapt to SCM API 2.0 APIs

            • Adds CrumbExclusion for notifyCommit hook
            • Adds a more efficient notify hook
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialCommitPayload.java src/main/java/hudson/plugins/mercurial/MercurialSCMHeadEvent.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java src/main/java/hudson/plugins/mercurial/MercurialStatus.java src/main/java/hudson/plugins/mercurial/MercurialStatusCrumbExclusion.java src/test/java/hudson/plugins/mercurial/MercurialSampleRepoRule.java src/test/java/hudson/plugins/mercurial/PipelineTest.java http://jenkins-ci.org/commit/mercurial-plugin/d0f8f4b930b96fd2da53ae50b0037163eb09ae48 Log: [JENKINS-39355 Follow-up] Adapt to SCM API 2.0 APIs Adds CrumbExclusion for notifyCommit hook Adds a more efficient notify hook
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/hudson/plugins/mercurial/MercurialCommitPayload.java
            src/main/java/hudson/plugins/mercurial/MercurialSCMHeadEvent.java
            src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
            src/main/java/hudson/plugins/mercurial/MercurialStatus.java
            src/main/java/hudson/plugins/mercurial/MercurialStatusCrumbExclusion.java
            src/test/java/hudson/plugins/mercurial/CustomConfigTest.java
            src/test/java/hudson/plugins/mercurial/MercurialSampleRepoRule.java
            src/test/java/hudson/plugins/mercurial/PipelineTest.java
            http://jenkins-ci.org/commit/mercurial-plugin/6d67081720f6732ae4c0f176eabbc92e713dbdd3
            Log:
            Merged #92: JENKINS-39355 Adapt to SCM API 2.0 APIs.

            Compare: https://github.com/jenkinsci/mercurial-plugin/compare/fc28fbf6038f...6d67081720f6

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialCommitPayload.java src/main/java/hudson/plugins/mercurial/MercurialSCMHeadEvent.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java src/main/java/hudson/plugins/mercurial/MercurialStatus.java src/main/java/hudson/plugins/mercurial/MercurialStatusCrumbExclusion.java src/test/java/hudson/plugins/mercurial/CustomConfigTest.java src/test/java/hudson/plugins/mercurial/MercurialSampleRepoRule.java src/test/java/hudson/plugins/mercurial/PipelineTest.java http://jenkins-ci.org/commit/mercurial-plugin/6d67081720f6732ae4c0f176eabbc92e713dbdd3 Log: Merged #92: JENKINS-39355 Adapt to SCM API 2.0 APIs. Compare: https://github.com/jenkinsci/mercurial-plugin/compare/fc28fbf6038f...6d67081720f6

            People

              stephenconnolly Stephen Connolly
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: