[JENKINS-39355] API improvements based on real-world implementation and usage

Type: Improvement
Resolution: Fixed
Priority: Minor
Component/s: scm-api-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

Various API improvements that make it easier to implement/consume SCM API:

Provide a way to perform probes without doing a full scan
Provide a way to allow scanning with custom criteria
Tweak the contract of SCMFileSystem to make it easier to implement/consume while reducing round trips
Clarify the difference between the SCMFileSystem view and the probe view.
Add categorization of SCMSource / SCMHead so that e.g. the Branch API can sort based on categories

is blocking

JENKINS-40299 Adapt to the new SCM API for detecting change requests

Closed

JENKINS-33273 Optimize Jenkinsfile loading and branch detection

Resolved

is duplicated by

JENKINS-42080 API to write a single file to the repository

Closed

JENKINS-39703 API to read a single file from the repository

Closed

links to

CloudBees Internal OSS-1598

Stephen Connolly created issue - 2016-10-28 14:19

SCM/JIRA link daemon added a comment - 2016-10-28 14:41

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMHeadObserver.java
http://jenkins-ci.org/commit/scm-api-plugin/02f0160ffab1078c12a299cbed034150f4959b25
Log:
~~JENKINS-39355~~ Add some more utility observers

SCM/JIRA link daemon added a comment - 2016-10-28 14:41 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMHeadObserver.java http://jenkins-ci.org/commit/scm-api-plugin/02f0160ffab1078c12a299cbed034150f4959b25 Log: JENKINS-39355 Add some more utility observers

SCM/JIRA link daemon added a comment - 2016-10-28 15:03

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMSource.java
src/main/java/jenkins/scm/impl/NullSCMSource.java
src/main/java/jenkins/scm/impl/SingleSCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/507eb1d02ff05478390c6b651927c0a63ec9f7c5
Log:
~~JENKINS-39355~~ Clarify what the requirement on implementations is with respect to the SCMSourceCriteria

Also SingleSCMSource is the only source that gets out of jail free

SCM/JIRA link daemon added a comment - 2016-10-28 15:03 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/impl/NullSCMSource.java src/main/java/jenkins/scm/impl/SingleSCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/507eb1d02ff05478390c6b651927c0a63ec9f7c5 Log: JENKINS-39355 Clarify what the requirement on implementations is with respect to the SCMSourceCriteria Also SingleSCMSource is the only source that gets out of jail free

SCM/JIRA link daemon added a comment - 2016-10-28 15:05

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMFileSystem.java
src/main/java/jenkins/scm/api/SCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/d900a04fd0071e1ccd7e873946d4d3b34a404a21
Log:
~~JENKINS-39355~~ Fix javadoc warnings

SCM/JIRA link daemon added a comment - 2016-10-28 15:05 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMFileSystem.java src/main/java/jenkins/scm/api/SCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/d900a04fd0071e1ccd7e873946d4d3b34a404a21 Log: JENKINS-39355 Fix javadoc warnings

SCM/JIRA link daemon added a comment - 2016-10-28 15:07

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/impl/ChangeRequestSCMHeadCategory.java
src/main/java/jenkins/scm/impl/UncategorizedSCMHeadCategory.java
src/main/java/jenkins/scm/impl/UncategorizedSCMSourceCategory.java
http://jenkins-ci.org/commit/scm-api-plugin/1c069908c873d6b2e264d38fd89ff7c8f3daa3ba
Log:
~~JENKINS-39355~~ Findbugs, the whole point is to tighten the annotations for the non-abstract classes

SCM/JIRA link daemon added a comment - 2016-10-28 15:07 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/impl/ChangeRequestSCMHeadCategory.java src/main/java/jenkins/scm/impl/UncategorizedSCMHeadCategory.java src/main/java/jenkins/scm/impl/UncategorizedSCMSourceCategory.java http://jenkins-ci.org/commit/scm-api-plugin/1c069908c873d6b2e264d38fd89ff7c8f3daa3ba Log: JENKINS-39355 Findbugs, the whole point is to tighten the annotations for the non-abstract classes

SCM/JIRA link daemon added a comment - 2016-10-28 15:18

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/38fc3a6cca5f95f8ef3d93780cf722de8c972c6c
Log:
~~JENKINS-39355~~ Oooh look... Findbugs found a bug... I suspect by accident though

SCM/JIRA link daemon added a comment - 2016-10-28 15:18 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/38fc3a6cca5f95f8ef3d93780cf722de8c972c6c Log: JENKINS-39355 Oooh look... Findbugs found a bug... I suspect by accident though

SCM/JIRA link daemon added a comment - 2016-11-01 12:43

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMNavigator.java
src/main/java/jenkins/scm/api/SCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/38612389b46d77951cbc97ee15595e2b1da2129a
Log:
~~JENKINS-39355~~ Add a hook for persistent actions that may be periodically refreshed

SCM/JIRA link daemon added a comment - 2016-11-01 12:43 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMNavigator.java src/main/java/jenkins/scm/api/SCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/38612389b46d77951cbc97ee15595e2b1da2129a Log: JENKINS-39355 Add a hook for persistent actions that may be periodically refreshed

SCM/JIRA link daemon added a comment - 2016-11-01 15:05

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMNavigator.java
src/main/java/jenkins/scm/api/SCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/1d87d73dea7677d1b7e2007e5b2c2eb210279fc4
Log:
~~JENKINS-39355~~ Fetching actions is something that needs to be able to log details

SCM/JIRA link daemon added a comment - 2016-11-01 15:05 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMNavigator.java src/main/java/jenkins/scm/api/SCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/1d87d73dea7677d1b7e2007e5b2c2eb210279fc4 Log: JENKINS-39355 Fetching actions is something that needs to be able to log details

SCM/JIRA link daemon added a comment - 2016-11-01 18:58

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/SCMNavigator.java
src/main/java/jenkins/scm/api/SCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/14cb4225cb17e251019d996f7e925167728778e8
Log:
~~JENKINS-39355~~ Fetching actions refinements

SCM/JIRA link daemon added a comment - 2016-11-01 18:58 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMNavigator.java src/main/java/jenkins/scm/api/SCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/14cb4225cb17e251019d996f7e925167728778e8 Log: JENKINS-39355 Fetching actions refinements

SCM/JIRA link daemon added a comment - 2016-11-03 10:20

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/jenkins/scm/api/MethodUtils.java
src/main/java/jenkins/scm/api/SCMNavigator.java
src/main/java/jenkins/scm/api/SCMSource.java
http://jenkins-ci.org/commit/scm-api-plugin/62c569c2be4e37b57e2d9bd62463fe9dbd546ccc
Log:
~~JENKINS-39355~~ Fix the isOverridden check to work on protected methods

SCM/JIRA link daemon added a comment - 2016-11-03 10:20 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/MethodUtils.java src/main/java/jenkins/scm/api/SCMNavigator.java src/main/java/jenkins/scm/api/SCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/62c569c2be4e37b57e2d9bd62463fe9dbd546ccc Log: JENKINS-39355 Fix the isOverridden check to work on protected methods

Assignee:: Stephen Connolly

Reporter:: Stephen Connolly

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 2016-10-28 14:19

Updated:: 2017-12-05 05:40

Resolved:: 2016-12-07 12:50

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-28 14:41

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-28 14:41

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:03

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:03

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:05

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:05

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:07

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:07

Collapse comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:18

Expand comment: SCM/JIRA link daemon added a comment - 2016-10-28 15:18

Collapse comment: SCM/JIRA link daemon added a comment - 2016-11-01 12:43

Expand comment: SCM/JIRA link daemon added a comment - 2016-11-01 12:43

Collapse comment: SCM/JIRA link daemon added a comment - 2016-11-01 15:05

Expand comment: SCM/JIRA link daemon added a comment - 2016-11-01 15:05

Collapse comment: SCM/JIRA link daemon added a comment - 2016-11-01 18:58

Expand comment: SCM/JIRA link daemon added a comment - 2016-11-01 18:58

Collapse comment: SCM/JIRA link daemon added a comment - 2016-11-03 10:20

Expand comment: SCM/JIRA link daemon added a comment - 2016-11-03 10:20

People

Dates