Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Won't Fix
Description
Adding an Active Choices Reactive Parameter with choice type of radio buttons or check boxes produces unnecessary scrollbars on the [build with parameters] screen (see attached image). Jenkins url is: https:// [ci_url] /job/ [job_name] /build?delay=0sec
Height calculation in the Javascript function of checkboxContent.jelly and radioContent.jelly seems to create a height value which is too small.
I have created a push request on GitHub with my own solution, should you choose to accept it.
Attachments
Activity
Java Dev
created issue -
Java Dev
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Environment |
- Operating System: Ubuntu Server 14.04 LTS 64Bit - Jenkins Version: 2.20 - Java(TM) SE Runtime Environment: (build 1.8.0_101-b13) - Not run in a container. - Debian install - Firefox 49.0.2 - Chrome Version 54.0.2840.71 (64-bit) |
- Operating System: Ubuntu Server 14.04 LTS 64Bit - Jenkins Version: 2.20 - Active Choices Plugin version: 1.40 - Java(TM) SE Runtime Environment: (build 1.8.0_101-b13) - Not run in a container. - Debian install - Firefox 49.0.2 - Chrome Version 54.0.2840.71 (64-bit) |
| Assignee | Bruno P. Kinoshita [ kinow ] | |
| Resolution | Won't Fix [ 2 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
Lubomir Stanko
added a comment - Active choices plugin is great, but this issue bothers me a lot.
Is this issue still not possible to do without breaking other stuff? I hope development moved forward a bit. So it maybe could be possible to fix now?
Lubomir Stanko
added a comment - Active choices plugin is great, but this issue bothers me a lot.
Is this issue still not possible to do without breaking other stuff? I hope development moved forward a bit. So it maybe could be possible to fix now? It should be doable stankolubomir. We just need someone with time to try a few variations, and come up with a solution that a) works well in most browsers, and b) works well with builds with 1 option, or with 100s of options. I intend to work on other issues related to performance and new features, but if you have time to give it a go, let me know and I'd be happy to review a pull request or patch. It should be doable to try a few variations in the browser inspector, without the need to clone the project and import in an IDE.
Lubomir Stanko
added a comment - kinow I've found some time to check and test it and I've created a pull request. Please check https://github.com/jenkinsci/active-choices-plugin/pull/21
Lubomir Stanko
added a comment - kinow I've found some time to check and test it and I've created a pull request. Please check https://github.com/jenkinsci/active-choices-plugin/pull/21 Hi stankolubomir,
Added comments to the pull request explaining why this approach would cause issues to other existing users of the plugin. Unfortunately I think we have to investigate other alternatives to workaround scroll bars or performance issues (or a completely different approach). But always thinking what will happen to other users 
Cheers
Bruno
Lubomir Stanko
added a comment - Hi kinow,
I've created another PR https://github.com/jenkinsci/active-choices-plugin/pull/22 . Now I'm setting height variable only for more than 10 choices. I suppose it is not necessary to set height for less than 10 choices. I believe most users have 3 to 5 choices. So at least these won't be affected by unnecessary scrollbars.
Thanks,
Lubo
Lubomir Stanko
added a comment - Hi kinow ,
I've created another PR https://github.com/jenkinsci/active-choices-plugin/pull/22 . Now I'm setting height variable only for more than 10 choices. I suppose it is not necessary to set height for less than 10 choices. I believe most users have 3 to 5 choices. So at least these won't be affected by unnecessary scrollbars.
Thanks,
Lubo
Tested the pull request, it would remove the scroll bar, but that would implicate a change in the plugin behavior that could cause issues to users with hundreds/thousands of options. Marking as won't fix.