Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39947

Job URLs do not work correctly with Folder plugin

      In case of multibranch pipelines which use Folders plugin and Folders plugin itself, job urls are not correctly reflect real action urls, so it is preferable to use absolute urls instead of short ones.

      There is a PR that allows for the action urls to be generated correctly by means of using job absolute urls instead of short ones.

      P.S. A few days ago JENKINS-31202 has been resolved, but in case of multibranch pipelines action urls (for created by means of Dashboard plugin are not generated correctly when using job's short urls).

      The PR mentioned above fixes action urls using absolute job url instead of short one.

          [JENKINS-39947] Job URLs do not work correctly with Folder plugin

          Sergey Zhemzhitsky created issue -
          Sergey Zhemzhitsky made changes -
          Link New: This issue is related to JENKINS-36536 [ JENKINS-36536 ]
          Sergey Zhemzhitsky made changes -
          Link New: This issue is related to JENKINS-31202 [ JENKINS-31202 ]
          Sergey Zhemzhitsky made changes -
          Description Original: In case of multibranch pipelines which use Folders plugin and Folders plugin itself, job urls are not correctly reflect real action urls, so it is preferable to use absolute urls instead of short ones.

          [There is a PR|https://github.com/jenkinsci/analysis-core-plugin/pull/37] that allows for the action urls to be generated correctly by means of using job absolute urls instead of short ones.
          New: In case of multibranch pipelines which use Folders plugin and Folders plugin itself, job urls are not correctly reflect real action urls, so it is preferable to use absolute urls instead of short ones.

          [There is a PR|https://github.com/jenkinsci/analysis-core-plugin/pull/37] that allows for the action urls to be generated correctly by means of using job absolute urls instead of short ones.

          P.S. A few days ago JENKINS-31202 has been resolved, but in case of multibranch pipelines action urls (for created by means of Dashboard plugin are not generated correctly when using job's short urls).

          The PR mentioned above fixes action urls using absolute job url instead of short one.
          Sergey Zhemzhitsky made changes -
          Link New: This issue is related to JENKINS-39950 [ JENKINS-39950 ]

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_collector/AnalysisCollectorAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_collector/WarningsPerProjectPortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AbstractTablePortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/checkstyle/CheckStyleAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/checkstyle/CheckStylePortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/dashboard_view/AbstractDashboardViewPortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/findbugs/FindBugsAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/findbugs/FindBugsPortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/pmd/PmdAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/pmd/PmdWarningsPortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TaskScannerAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TasksColumn.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TasksPortlet.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/WarningsAction.java
          src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/WarningsPortlet.java
          src/main/java/org/jenkinsci/test/acceptance/po/AbstractListViewColumn.java
          src/main/java/org/jenkinsci/test/acceptance/po/Build.java
          src/test/java/plugins/AbstractAnalysisTest.java
          src/test/java/plugins/AnalysisCollectorPluginTest.java
          src/test/java/plugins/CheckStylePluginTest.java
          src/test/java/plugins/FindBugsPluginTest.java
          src/test/java/plugins/PmdPluginTest.java
          src/test/java/plugins/WarningsPluginTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/a94aef1e8d8d340bd7bd01ba67ba7716fbea8b36
          Log:
          Pulled column and portlet tests up to AbstractAnalysisTest.

          Now all static analysis plug-ins have a common test that checks that the number of warnings is shown as a link in the warnings column and warnings table portlet.
          Currently a test does not check the URL itself it rather clicks the link to see if the navigation works. This could be used as a basis for JENKINS-39947.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_collector/AnalysisCollectorAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_collector/WarningsPerProjectPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AbstractTablePortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/checkstyle/CheckStyleAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/checkstyle/CheckStylePortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/dashboard_view/AbstractDashboardViewPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/findbugs/FindBugsAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/findbugs/FindBugsPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/pmd/PmdAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/pmd/PmdWarningsPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TaskScannerAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TasksColumn.java src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TasksPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/WarningsAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/WarningsPortlet.java src/main/java/org/jenkinsci/test/acceptance/po/AbstractListViewColumn.java src/main/java/org/jenkinsci/test/acceptance/po/Build.java src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/FindBugsPluginTest.java src/test/java/plugins/PmdPluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/a94aef1e8d8d340bd7bd01ba67ba7716fbea8b36 Log: Pulled column and portlet tests up to AbstractAnalysisTest. Now all static analysis plug-ins have a common test that checks that the number of warnings is shown as a link in the warnings column and warnings table portlet. Currently a test does not check the URL itself it rather clicks the link to see if the navigation works. This could be used as a basis for JENKINS-39947 .

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java
          src/main/java/org/jenkinsci/test/acceptance/po/Container.java
          src/main/java/org/jenkinsci/test/acceptance/po/Folder.java
          src/main/java/org/jenkinsci/test/acceptance/po/FolderItem.java
          src/main/java/org/jenkinsci/test/acceptance/po/Jenkins.java
          src/main/java/org/jenkinsci/test/acceptance/po/TopLevelItem.java
          src/main/java/org/jenkinsci/test/acceptance/po/WorkflowMultiBranchJob.java
          src/test/java/plugins/AbstractAnalysisTest.java
          src/test/java/plugins/AnalysisCollectorPluginTest.java
          src/test/java/plugins/CheckStylePluginTest.java
          src/test/java/plugins/FindBugsPluginTest.java
          src/test/java/plugins/FolderPluginTest.java
          src/test/java/plugins/PmdPluginTest.java
          src/test/java/plugins/TaskScannerPluginTest.java
          src/test/java/plugins/WarningsPluginTest.java
          http://jenkins-ci.org/commit/acceptance-test-harness/02c3799d89681b2447cffaa5380f45f803db9959
          Log:
          Added test case to expose JENKINS-39947 JENKINS-39950.

          The test case runs the static analysis plugins for a job that is part of a folder.

          Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/87a407ef80af...02c3799d8968

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java src/main/java/org/jenkinsci/test/acceptance/po/Container.java src/main/java/org/jenkinsci/test/acceptance/po/Folder.java src/main/java/org/jenkinsci/test/acceptance/po/FolderItem.java src/main/java/org/jenkinsci/test/acceptance/po/Jenkins.java src/main/java/org/jenkinsci/test/acceptance/po/TopLevelItem.java src/main/java/org/jenkinsci/test/acceptance/po/WorkflowMultiBranchJob.java src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/FindBugsPluginTest.java src/test/java/plugins/FolderPluginTest.java src/test/java/plugins/PmdPluginTest.java src/test/java/plugins/TaskScannerPluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/02c3799d89681b2447cffaa5380f45f803db9959 Log: Added test case to expose JENKINS-39947 JENKINS-39950 . The test case runs the static analysis plugins for a job that is part of a folder. Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/87a407ef80af...02c3799d8968

          Ulli Hafner added a comment - - edited

          szhemzhitsky: Can you please have a look at the test case I have added to the ATH. Seems to work. Which link is exactly broken in this issue? Is something different in your setup?

          Ulli Hafner added a comment - - edited szhemzhitsky : Can you please have a look at the test case I have added to the ATH. Seems to work. Which link is exactly broken in this issue? Is something different in your setup?
          Ulli Hafner made changes -
          Link Original: This issue is related to JENKINS-36536 [ JENKINS-36536 ]
          Sergey Zhemzhitsky made changes -

            drulli Ulli Hafner
            szhem Sergey Zhemzhitsky
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: