Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40098

Bundle naming strategy should be able to specify an instance type

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When one has to handle a lot of support bundles coming from different servers, it can make sense to be able to override the default prefix support (see related code).

      So I think the existing code should be refactored to accept using something like a pluggable strategy.

      Currently, there is already the SupportProvider.getName() class which lets you customize the beginning of the bundle name. Being able to insert an additional information would be helpful for the purpose explained above.

        Attachments

          Issue Links

          links to

          Web Link CloudBees Internal CJP-5955

          Web Link PR 92

            Activity

            Ascending order - Click to sort in descending order
            batmat Baptiste Mathus created issue -
            Hide
            Permalink
            jglick Jesse Glick added a comment -

            Please remember to link from PR to JIRA and back, and set the status.

            Show
            jglick Jesse Glick added a comment - Please remember to link from PR to JIRA and back, and set the status.
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Remote Link This issue links to "PR 91 (Web Link)" [ 15078 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            batmat Baptiste Mathus made changes -
            Summary The support bundle naming strategy should be modifiable Bundle naming strategy should be able to specify an instance type
            batmat Baptiste Mathus made changes -
            Description When one has to handle a lot of support bundles coming from different servers, it can make sense to be able to override the default prefix {{support}} (see [related code|https://github.com/jenkinsci/support-core-plugin/blob/98e849886a10f3907fb1027a280fb23aab211ede/src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java#L716]).

            So I think the existing code should be refactored to accept using something like a pluggable strategy.             		When one has to handle a lot of support bundles coming from different servers, it can make sense to be able to override the default prefix {{support}} (see [related code|https://github.com/jenkinsci/support-core-plugin/blob/98e849886a10f3907fb1027a280fb23aab211ede/src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java#L716]).

            So I think the existing code should be refactored to accept using something like a pluggable strategy.

            Currently, there is already the SupportProvider.getName() class which lets you customize the beginning of the bundle name. Being able to insert an additional information would be helpful for the purpose explained above.
            batmat Baptiste Mathus made changes -
            Remote Link Cette demande est liée à "PR 92 (Lien Web)" [ 15083 ]
            batmat Baptiste Mathus made changes -
            Remote Link Cette demande est liée à "PR 91 (Lien Web)" [ 15078 ]
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            src/main/java/com/cloudbees/jenkins/support/BundleNameInstanceTypeProvider.java
            src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java
            src/test/java/com/cloudbees/jenkins/support/BundleNamePrefixTest.java
            http://jenkins-ci.org/commit/support-core-plugin/b7ee94fd00eaf77fd0526acffdbd5641f5b7abc6
            Log:
            JENKINS-40098 Bundle naming strategy should be able to specify an instance type

            Introduced a change enabling both overriding through using a sysprop,
            or by implementing a new Extension Point.

            The approach with Extension Points should enable more dynamic needs,
            when the sysprop one will be immediately usable by anyone without
            having to develop an extension.

            Note: if found, the extension is preferred over the sysprop.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/com/cloudbees/jenkins/support/BundleNameInstanceTypeProvider.java src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java src/test/java/com/cloudbees/jenkins/support/BundleNamePrefixTest.java http://jenkins-ci.org/commit/support-core-plugin/b7ee94fd00eaf77fd0526acffdbd5641f5b7abc6 Log: JENKINS-40098 Bundle naming strategy should be able to specify an instance type Introduced a change enabling both overriding through using a sysprop, or by implementing a new Extension Point. The approach with Extension Points should enable more dynamic needs, when the sysprop one will be immediately usable by anyone without having to develop an extension. Note: if found, the extension is preferred over the sysprop.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            src/main/java/com/cloudbees/jenkins/support/BundleNameInstanceTypeProvider.java
            src/main/java/com/cloudbees/jenkins/support/SupportAction.java
            src/main/java/com/cloudbees/jenkins/support/SupportCommand.java
            src/main/java/com/cloudbees/jenkins/support/SupportLogFormatter.java
            src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java
            src/test/java/com/cloudbees/jenkins/support/BundleNamePrefixTest.java
            http://jenkins-ci.org/commit/support-core-plugin/80b611d0d3a3fff0cb5593c75d6d8b9338d862e1
            Log:
            Merge pull request #92 from batmat/JENKINS-40098-take-2

            JENKINS-40098 Bundle naming strategy should be able to specify an instance type

            Compare: https://github.com/jenkinsci/support-core-plugin/compare/fc3119380c83...80b611d0d3a3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/com/cloudbees/jenkins/support/BundleNameInstanceTypeProvider.java src/main/java/com/cloudbees/jenkins/support/SupportAction.java src/main/java/com/cloudbees/jenkins/support/SupportCommand.java src/main/java/com/cloudbees/jenkins/support/SupportLogFormatter.java src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java src/test/java/com/cloudbees/jenkins/support/BundleNamePrefixTest.java http://jenkins-ci.org/commit/support-core-plugin/80b611d0d3a3fff0cb5593c75d6d8b9338d862e1 Log: Merge pull request #92 from batmat/ JENKINS-40098 -take-2 JENKINS-40098 Bundle naming strategy should be able to specify an instance type Compare: https://github.com/jenkinsci/support-core-plugin/compare/fc3119380c83...80b611d0d3a3
            Hide
            Permalink
            batmat Baptiste Mathus added a comment -

            Released in 2.37

            Show
            batmat Baptiste Mathus added a comment - Released in 2.37
            batmat Baptiste Mathus made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal CJP-5955 (Web Link)" [ 19223 ]
            aheritier Arnaud Héritier made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              Assignee:
              batmat Baptiste Mathus
              Reporter:
              batmat Baptiste Mathus
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: