-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
Jenkins 2.19.4, fresh Pipeline installation as of 2016-12-08
When configuring a Shared Library, after selecting "Legacy SCM" or "Modern SCM" the SCM options are listed with a radio selection UI element.
Unfortunately there is no item in that radio selection that is selected by default, meaning if the user doesn't notice nothing has been actually selected in the radio selection, might Save the configuration and be very confused with their Shared Libraries don't work.
- depends on
-
JENKINS-19584 Ability to redirect user to configuration screen when erroneous data is saved
-
- Open
-
- links to
[JENKINS-40323] No SCM selected when adding a shared library
Is this true for modern SCM, too?
Should error on saving if they don't select something. I wouldn't want to choose a default for users. There's too much configuration needed to have a real default.
Yes the issue exists when selecting either "SCM" option. And unfortunately the configuration page will happily save (but not persist any configuration of course) without a validation error.
What is "modern scm" vs "legacy scm"?
This is some implementation detail about whether a full clone is needed to get the library code or not. Something like that, has nothing to do with the SCM and everything with the SCM plugin from my recollection
It's based on usage the of scm-api-plugin as far as I know but I'm not 100% sure how it is related. jglick or stephenconnolly know more about it than anyone.
I think we need a more descriptive term for them but I'm not sure what we could call them.
FWIW “legacy” vs. “modern” simply refers to whether the SCM plugin is implementing the recommended APIs, or whether we need to fall back to a workaround compatible with older SCM plugins.
jglick whats the difference as far as the users concerned? Any behavioural difference or is it just a implementation detail?
jamesdumay yes, legacy means
- you must use the ${library.NAME.version} hack
- there is unlikely to be support for @abc1234 and generally selecting anything other than a branch head
hrmpw we should revisit this and give it some design love.