Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40376

Build must fail, if branch spec is an empty string

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Won't Fix
    • git-plugin
    • None
    • git-plugin version 3.0.1
      jenkins 2.7.4

    Description

      Use case:

      Create a freestyle build project with the following settings:

      • This build is parameterized
        Name = BRANCH_SPECIFIER
        Default Value = <leave blank>
        Source Code Management
        Git
      • Branch Specifier (blank for default): = $BRANCH_SPECIFIER

      Expected:
      The build must fail with ERROR because of $BRANCH_SPECIFIER was set as empty and explicit better then implicit. If you want branch spec as "*", then you should set $BRANCH_SPECIFIER was set as "*".

      Actually:
      $BRANCH_SPECIFIER was set as "**" and job will start in an infinite loop. Build for the build.

      Changes inserted in JENKINS-8656 need to be rolled back because they is non logical and misleading.
      Commit https://github.com/jenkinsci/git-plugin/commit/dc575dce269020afe79bf0224c906b2520c5438d

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-8656 Git SCM fails to build with parameterized builds with empty string

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            markewaite Mark Waite added a comment -

            We don't change default behaviors of the git plugin, even if one or more users feel they are

            non logical and misleading

            Too many users and installations depend on the default behaviors, and too little benefit would be gained by requiring them to change their parameterized jobs or their automation which launches jobs.

            markewaite Mark Waite added a comment - We don't change default behaviors of the git plugin, even if one or more users feel they are non logical and misleading Too many users and installations depend on the default behaviors, and too little benefit would be gained by requiring them to change their parameterized jobs or their automation which launches jobs.

            People

              markewaite Mark Waite
              sh0ked Nikolay Ustinov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: