Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40802

ghprbCommentBody contains stale values

    XMLWordPrintable

Details

    Description

      If I have a Jenkins job with 'Trigger phrase' set to 'redo', then when I type 'redo' on the PR a Jenkins job is correctly triggered with 'ghprbCommentBody' set to 'redo'.

      However, if I then push another commit to this PR, then a Jenkins job is created with 'ghprbCommentBody' again set to 'redo', rather than 'null'.

      It looks like at the same time as setting `int commentsChecked = 0;` at GhprbPullRequest.java:245 we should also set `commentBody = null;`.

      Attachments

        Issue Links

          links to

          Web Link GitHub issue 233

          Activity

            Ascending order - Click to sort in descending order
            sag47 Sam Gleske added a comment - - edited

            Proposed PR https://github.com/jenkinsci/ghprb-plugin/pull/504

            This duplicates GitHub issue: https://github.com/jenkinsci/ghprb-plugin/issues/233

            sag47 Sam Gleske added a comment - - edited Proposed PR https://github.com/jenkinsci/ghprb-plugin/pull/504 This duplicates GitHub issue:  https://github.com/jenkinsci/ghprb-plugin/issues/233
            sag47 Sam Gleske added a comment -

            Closing as duplicate of GitHub issue.

            sag47 Sam Gleske added a comment - Closing as duplicate of GitHub issue.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dominic Hargreaves
            Path:
            src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java
            http://jenkins-ci.org/commit/ghprb-plugin/753a77fc1eecf803e6218888fa746b62dedea9e4
            Log:
            Fix for stale ghprbCommentBody values (#233/JENKINS-40802)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dominic Hargreaves Path: src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java http://jenkins-ci.org/commit/ghprb-plugin/753a77fc1eecf803e6218888fa746b62dedea9e4 Log: Fix for stale ghprbCommentBody values (#233/ JENKINS-40802 )
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Gleske
            Path:
            src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java
            http://jenkins-ci.org/commit/ghprb-plugin/c943b3038b98f73b183b527d6ae3da7d58667e6e
            Log:
            Merge pull request #504 from jmdh/fix-stale-comment-body

            Fix for stale ghprbCommentBody values (#233/JENKINS-40802)

            Compare: https://github.com/jenkinsci/ghprb-plugin/compare/80c0765af51b...c943b3038b98

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java http://jenkins-ci.org/commit/ghprb-plugin/c943b3038b98f73b183b527d6ae3da7d58667e6e Log: Merge pull request #504 from jmdh/fix-stale-comment-body Fix for stale ghprbCommentBody values (#233/ JENKINS-40802 ) Compare: https://github.com/jenkinsci/ghprb-plugin/compare/80c0765af51b...c943b3038b98

            People

              sag47 Sam Gleske
              ian_semmle Ian Lynagh
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: