Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40926

Persist accepted input values

    XMLWordPrintable

Details

    Description

      Use case
      Developers would like to see the provided input parameters in the UI after the execution of the input step has been completed. This provides additional context about who proceeded on input and what parameters were passed.

      Today the input step throws away the execution data which means we are unable to later display it to the user. If the Input Step persisted its execution and values then we could build a UI for this.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-40672 Display accepted Pipeline input parameters

          • Major - Major loss of function.
          • Open
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-43857 PasswordParameterDefinition should be filtered from InputSubmittedAction

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Review
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-30972 Add a way to distinguish workflow input steps approvals shown on the build page

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link CloudBees Internal UX-609

          Web Link PR #12

          Activity

            Ascending order - Click to sort in descending order
            jamesdumay James Dumay created issue -
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            jamesdumay James Dumay made changes -
            Link This issue blocks JENKINS-40672 [ JENKINS-40672 ]
            jamesdumay James Dumay made changes -
            Description *Use case*
            Developers would like to see the provided input parameters in the UI after the execution of the input step has been completed. This provides additional context about who proceeded on input and what parameters were passed.

            Today the input step throws away the execution data which means we are unable to later display it to the user.             		*Use case*
            Developers would like to see the provided input parameters in the UI after the execution of the input step has been completed. This provides additional context about who proceeded on input and what parameters were passed.

            Today the input step throws away the execution data which means we are unable to later display it to the user. If the Input Step persisted its execution and values then we could build a good API for this.
            jamesdumay James Dumay made changes -
            Description *Use case*
            Developers would like to see the provided input parameters in the UI after the execution of the input step has been completed. This provides additional context about who proceeded on input and what parameters were passed.

            Today the input step throws away the execution data which means we are unable to later display it to the user. If the Input Step persisted its execution and values then we could build a good API for this.             		*Use case*
            Developers would like to see the provided input parameters in the UI after the execution of the input step has been completed. This provides additional context about who proceeded on input and what parameters were passed.

            Today the input step throws away the execution data which means we are unable to later display it to the user. If the Input Step persisted its execution and values then we could build a UI for this.
            abayer Andrew Bayer added a comment -

            So we do have the user via ApproverAction, but only for the whole Run. So we need to expand that to the other parameters and save it to the FlowNode as well.

            abayer Andrew Bayer added a comment - So we do have the user via ApproverAction , but only for the whole Run . So we need to expand that to the other parameters and save it to the FlowNode as well.
            abayer Andrew Bayer made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            abayer Andrew Bayer made changes -
            Assignee Andrew Bayer [ abayer ]
            abayer Andrew Bayer made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            abayer Andrew Bayer added a comment -

            Initial PR up at https://github.com/jenkinsci/pipeline-input-step-plugin/pull/12

            abayer Andrew Bayer added a comment - Initial PR up at  https://github.com/jenkinsci/pipeline-input-step-plugin/pull/12
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "PR #12 (Web Link)" [ 15906 ]
            jglick Jesse Glick added a comment -

            JENKINS-30972 seems related.

            jglick Jesse Glick added a comment - JENKINS-30972 seems related.
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-30972 [ JENKINS-30972 ]
            abayer Andrew Bayer made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputSubmittedAction.java
            src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java
            http://jenkins-ci.org/commit/pipeline-input-step-plugin/fa9a7282c3e2f142805dbeeddf934db3fe0fc36f
            Log:
            [FIXED JENKINS-40926] Persist input submission parameters and user on node

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputSubmittedAction.java src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/fa9a7282c3e2f142805dbeeddf934db3fe0fc36f Log: [FIXED JENKINS-40926] Persist input submission parameters and user on node
            jamesdumay James Dumay added a comment -

            Thank you!

            jamesdumay James Dumay added a comment - Thank you!
            jglick Jesse Glick made changes -
            Link This issue is blocked by JENKINS-43857 [ JENKINS-43857 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal UX-609 (Web Link)" [ 18198 ]

            People

              abayer Andrew Bayer
              jamesdumay James Dumay
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: