Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41276

Abort doesn't work with Retry

    XMLWordPrintable

Details

    Description

      When using a retry wrapper in Pipeline you cannot abort during the retry, the abort is treated as any other failiure.

      Attachments

        1. console
          1 kB
        2. Jenkinsfile
          0.2 kB

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-37128 Retry build step incompatible with canceling builds

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-41774 Pipeline executes "retry" when pipeline is aborted

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-44379 workflow-basic-steps: retry does not abort when input or milestone try to abort build

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link PR 34

          Web Link workflow-basic-steps PR 35

          Web Link workflow-cps PR 103

          Web Link workflow-job PR 36

          Web Link workflow-step-api PR 20

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
            src/test/java/org/jenkinsci/plugins/workflow/steps/RetryStepTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/422295a5dbac5192e0320d916fb37838e3c24c87
            Log:
            [FIXED JENKINS-41276] Do not continue to retry when the failure is a user interruption.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/steps/RetryStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/422295a5dbac5192e0320d916fb37838e3c24c87 Log: [FIXED JENKINS-41276] Do not continue to retry when the failure is a user interruption.
            jglick Jesse Glick added a comment -

            Possibly should be extended to handle aborts coming from timeout, or perhaps any cause.

            jglick Jesse Glick added a comment - Possibly should be extended to handle aborts coming from timeout , or perhaps any cause.
            bkmeneguello Bruno Meneguello added a comment -

            Still now working.
            Pipeline: Basic Steps 2.6
            sample: Jenkinsfileoutput: console

            bkmeneguello Bruno Meneguello added a comment - Still now working. Pipeline: Basic Steps 2.6 sample:  Jenkinsfile output:  console
            timja Tim Jacomb added a comment - - edited

            I'm also having the same issue as Bruno...

            Apologies my issue looks different I'm catching the exception which interferes

            timja Tim Jacomb added a comment - - edited I'm also having the same issue as Bruno... Apologies my issue looks different I'm catching the exception which interferes
            b_dean Ben Dean added a comment -

            Just ran into this and I imagine my scenario is similar to what bkmeneguello and timja were getting.

            If you have an exception thrown in a finally block it'll win out instead of the FlowInterruptedException

            retry(5) {
    try {
        sh "do_something_slow"
    } finally {
        echo "Cleaning up"

        // Do something that raises an exception
        def x = 1/0
    }
}

            You'll end up losing the abort exception and retrying again even though you aborted. Same thing with timeouts.

            b_dean Ben Dean added a comment - Just ran into this and I imagine my scenario is similar to what  bkmeneguello and timja were getting. If you have an exception thrown in a finally block it'll win out instead of the FlowInterruptedException retry(5) { try { sh "do_something_slow" } finally { echo "Cleaning up" // Do something that raises an exception def x = 1/0 } } You'll end up losing the abort exception and retrying again even though you aborted. Same thing with timeouts.

            People

              jglick Jesse Glick
              hrmpw Patrick Wolf
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: