Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
-
-
1.0
Description
In Scope
- If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed.
- Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message.
- The toast should use the failure style
Reproduce
You can make favouriting fail by:
- Create a multibranch pipeline with no branches
- Go to the dashboard
- Favourite the pipeline
REST data
REST call will fail with:
{
"message" : "no master branch to favorite",
"code" : 400,
"errors" : [ ]
}
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | JENKINS-35761 [ 171656 ] |
| Rank | Ranked higher |
| Summary | Handle when favouriting fails | Handle when favouriting a pipeline fails |
| Issue Type | Improvement [ 4 ] | Bug [ 1 ] |
| Assignee | Tom FENNELLY [ tfennelly ] |
| Sprint | post-release [ 181 ] | panthalassa [ 221 ] |
| Rank | Ranked lower |
| Sprint | panthalassa [ 221 ] | iapetus [ 216 ] |
| Rank | Ranked lower |
| Sprint | iapetus [ 216 ] |
| Sprint | 1.0 [ 221 ] |
| Rank | Ranked higher |
| Rank | Ranked lower |
| Rank | Ranked lower |
| Description |
If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} |
If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} *Scope* * Show the failure toast in this case |
| Description |
If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} *Scope* * Show the failure toast in this case |
*In Scope* If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message *Reproduce* You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} *Scope* * Show the failure toast in this case |
| Description |
*In Scope* If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message *Reproduce* You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} *Scope* * Show the failure toast in this case |
*In Scope* If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message *Reproduce* You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline *REST data* REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} *Scope* * Show the failure toast in this case |
| Description |
*In Scope* If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message *Reproduce* You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline *REST data* REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} *Scope* * Show the failure toast in this case |
*In Scope* * If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. * Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message. * The toast should use the failure style *Reproduce* You can make favouriting fail by: # Create a multibranch pipeline with no branches # Go to the dashboard # Favourite the pipeline *REST data* REST call will fail with: {code} { "message" : "no master branch to favorite", "code" : 400, "errors" : [ ] } {code} |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
Jenn Briden
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
https://github.com/jenkinsci/blueocean-plugin/pull/876
https://github.com/jenkinsci/jenkins-design-language/pull/156