Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41642

Handle when favouriting a pipeline fails

    XMLWordPrintable

Details

    • 1.0

    Description

      In Scope

      • If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed.
      • Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message.
      • The toast should use the failure style

      Reproduce
      You can make favouriting fail by:

      1. Create a multibranch pipeline with no branches
      2. Go to the dashboard
      3. Favourite the pipeline

      REST data
      REST call will fail with:

      {
        "message" : "no master branch to favorite",
        "code" : 400,
        "errors" : [ ]
      }
      

      Attachments

        Activity

          jamesdumay James Dumay created issue -
          jamesdumay James Dumay made changes -
          Field Original Value New Value
          Epic Link JENKINS-35761 [ 171656 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Summary Handle when favouriting fails Handle when favouriting a pipeline fails
          jamesdumay James Dumay made changes -
          Issue Type Improvement [ 4 ] Bug [ 1 ]
          jamesdumay James Dumay made changes -
          Assignee Tom FENNELLY [ tfennelly ]
          jamesdumay James Dumay made changes -
          Sprint post-release [ 181 ] panthalassa [ 221 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint panthalassa [ 221 ] iapetus [ 216 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint iapetus [ 216 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0 [ 221 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Description If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user

          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}
          If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user

          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}

          *Scope*
          * Show the failure toast in this case
          jamesdumay James Dumay made changes -
          Description If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user

          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}

          *Scope*
          * Show the failure toast in this case
          *In Scope*
          If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message

          *Reproduce*
          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}

          *Scope*
          * Show the failure toast in this case
          jamesdumay James Dumay made changes -
          Description *In Scope*
          If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message

          *Reproduce*
          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}

          *Scope*
          * Show the failure toast in this case
          *In Scope*
          If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message

          *Reproduce*
          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          *REST data*
          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}

          *Scope*
          * Show the failure toast in this case
          jamesdumay James Dumay made changes -
          Description *In Scope*
          If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message

          *Reproduce*
          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          *REST data*
          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}

          *Scope*
          * Show the failure toast in this case
          *In Scope*
          * If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed.
          * Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message.
          * The toast should use the failure style

          *Reproduce*
          You can make favouriting fail by:
          # Create a multibranch pipeline with no branches
          # Go to the dashboard
          # Favourite the pipeline

          *REST data*
          REST call will fail with:
          {code}
          {
            "message" : "no master branch to favorite",
            "code" : 400,
            "errors" : [ ]
          }
          {code}
          tfennelly Tom FENNELLY made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tfennelly Tom FENNELLY made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          tfennelly Tom FENNELLY added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/876 https://github.com/jenkinsci/jenkins-design-language/pull/156
          tfennelly Tom FENNELLY made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          jbriden Jenn Briden made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            tfennelly Tom FENNELLY
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: