Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41827

JenkinsRule mode to use realistic class loading

    XMLWordPrintable

Details

    Description

      JenkinsRule-based tests generally load not only Jenkins core but also all plugins from ${java.class.path}, i.e., the Maven test-scoped classpath. This is convenient in some ways but also means that class loading is done in a very different way than in an actual production instance, or even mvn hpi:run, making it very hard to test changes like JENKINS-26192 without using the much clunkier, slower, and flakier acceptance-test-harness. It also means that we are forever fighting with Maven's weird transitive dependency management (JENKINS-41631, JENKINS-39301, etc.).

      There should be an option to run JenkinsRule in a mode whereby the test classpath is only used to load Jetty; Jenkins core and its WEB-INF/lib/*.jar (including modules!) is loaded in a derivative class loader; and then plugins are discovered from the test classpath, transitive dependencies computed and verified, and finally loaded in the real plugin class loader (probably using *.jpl files to allow us to still load from unpacked development trees). Finally, the test suite itself needs to be reloaded in a fresh loader parented to UberClassLoader, and executed from there.

      NbModuleSuite demonstrates the concept, though the details would be rather different for Jenkins.

      There are a lot of details to be checked, such as

      • @TestExtension handling
      • PluginWorkspaceMap support for coördinated snapshot development
      • moving InjectedTest from HudsonTestCase so that it can use the new mode

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. JENKINS-5303 Upgrade Acegi Security to the latest Spring Security release

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved
          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-62776 NoClassDefFoundErrors after updating

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is blocking

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-50520 Remove jClouds shading

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-59442 NoClassDefFoundError of application classes during test

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-31068 The reverse proxy monitor doesn't verify anymore if org.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true on Tomcat

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48357 Binary Compatibility between JIRA Plugin and Apache HttpComponents Client 4.x API

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-46754 2.73+ SSH agent sometimes will not start if using passphrase-protected ed25519 key

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-19508 Replace @Extension(optional=true) and optional dependencies with bridge plugins

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-41631 Use requireUpperBoundDeps in plugin POM

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-39301 During test executions optional transitive plugin dependencies don't get correctly loaded

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26579 j:getStatic/invokeStatic does not work on plugin classes

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-60295 jenkins-test-harness does not handle detached plugins properly

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-61007 pipeline-model-definition is using findbugs without providing / depending on it

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-51779 Use of beta Guava method since deleted: Iterators.skip

          • Major - Major loss of function.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-47118 Extend InjectedTest to include test runs with all optional plugins disabled

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-30685 Hide core dependencies in plugin classpath

          • Major - Major loss of function.
          • Open
          links to

          Web Link CloudBees Internal OSS-1951

          Web Link jenkins-test-harness #280

          Activity

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              4 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: