Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41980

"Suppress automatic SCM triggering" property must be respected when events trigger the build

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • branch-api-plugin
    • Jenkins 2.45
      GitHub plugin 1.26.0
      Branch API Plugin 2.0.4

      Steps to reproduce:

      1. Create multibranch pipeline project.
      2. Under project configuration, add GitHub source.
      3. Select "All branches get the same properties" under Property Strategy.
      4. Add "Suppress automatic SCM triggering" property.
      5. Save configuration.
      6. Make sure that GitHub repo configured at step 2 sends push notifications to your Jenkins instance via /github-webhook endpoint.
      7. Push something to the repo.

      Expected result

      Build triggering was suppressed.

      Actual result

      Build is triggered.

      This got broken after recent 1.x -> 2.x updates to SCM API and Co.

          [JENKINS-41980] "Suppress automatic SCM triggering" property must be respected when events trigger the build

          Vladislav Ponomarev added a comment - How about https://github.com/jenkinsci/branch-api-plugin/pull/83 ?

          Code changed in jenkins
          User: Vladislav Ponomarev
          Path:
          src/main/java/jenkins/branch/NoTriggerBranchProperty.java
          src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java
          http://jenkins-ci.org/commit/branch-api-plugin/d7334e5a0399895ac0abfad8a9bab5b3fa8c2b39
          Log:
          JENKINS-41980 SCM triggering should also be suppressed for GitHub webhooks.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vladislav Ponomarev Path: src/main/java/jenkins/branch/NoTriggerBranchProperty.java src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java http://jenkins-ci.org/commit/branch-api-plugin/d7334e5a0399895ac0abfad8a9bab5b3fa8c2b39 Log: JENKINS-41980 SCM triggering should also be suppressed for GitHub webhooks.

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/NoTriggerBranchProperty.java
          src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java
          http://jenkins-ci.org/commit/branch-api-plugin/a8ae07cbc48c205a0c8a4c507ff20fbb7075411d
          Log:
          Merge pull request #83 from anenviousguest/master

          JENKINS-41980 SCM triggering should also be suppressed for branch events

          Compare: https://github.com/jenkinsci/branch-api-plugin/compare/717536bff4fb...a8ae07cbc48c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/NoTriggerBranchProperty.java src/main/java/jenkins/branch/NoTriggerOrganizationFolderProperty.java http://jenkins-ci.org/commit/branch-api-plugin/a8ae07cbc48c205a0c8a4c507ff20fbb7075411d Log: Merge pull request #83 from anenviousguest/master JENKINS-41980 SCM triggering should also be suppressed for branch events Compare: https://github.com/jenkinsci/branch-api-plugin/compare/717536bff4fb...a8ae07cbc48c

          I think this introduced a bug, as the original idea of this property was to supress only build from indexing. Now all git hooks are suppressed as well.... see JENKINS-45814

          Thomas Schneider added a comment - I think this introduced a bug, as the original idea of this property was to supress only build from indexing. Now all git hooks are suppressed as well.... see JENKINS-45814

          Nope this fixed a bug, Suppressing SCM Triggers should suppress all builds triggered by a detected change in the SCM irrespective of how the change was detected

          Stephen Connolly added a comment - Nope this fixed a bug, Suppressing SCM Triggers should suppress all builds triggered by a detected change in the SCM irrespective of how the change was detected

            anenviousguest Vladislav Ponomarev
            anenviousguest Vladislav Ponomarev
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: