Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42194

SCMTrigger should not give a warning when used to suppress post-commit hooks

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      The Poll SCM trigger has two purposes:

      1. Setting a cadence for polling SCM
      2. Declaring that post commit hooks should be ignored

      Currently if you want to ignore post commit hooks you are supposed to configure the trigger like so:

      Now the issue here is that we are displaying a warning for a desired configuration. This leads users to think that they are doing something wrong.

      As a consequence of this, we have had developers of other plugins add their own trigger implementations to control push trigger ignore behaviour (see GitHub plugin for an example)

      What we really want is that the field validation should state that empty polling is OK when ignoring triggers:

      But retain the field validation when either not ignoring hooks or ignoring hooks but invalid spec

          [JENKINS-42194] SCMTrigger should not give a warning when used to suppress post-commit hooks

          Stephen Connolly created issue -
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Stephen Connolly made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Stephen Connolly made changes -
          Remote Link New: This issue links to "PR#2758 (Web Link)" [ 15467 ]
          Daniel Beck made changes -
          Labels New: lts-candidate
          Daniel Beck made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 2.46.2-fixed
          Stephen Connolly made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: