Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42524

Don't blacklist GStringImpl from XStream serialization

    XMLWordPrintable

Details

    Description

      So I wanted to discuss this, in case there's a good reason for rejecting org.codehaus.groovy.runtime.GStringImpl specifically. We're currently blacklisting org.codehaus.groovy.runtime.* in hudson.remoting.ClassFilter.DEFAULT and that can cause hassles, so I thought it was worth discussion.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-43934 GString kept unevaluated as long as StepDescriptor.newInstance (was: Pipeline build fails with serialization error when using string interpolation)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-44873 UnsupportedOperationException - Refusing to marshal org.codehaus.groovy.runtime.GStringImpl

          • Major - Major loss of function.
          • Reopened
          links to

          Web Link CloudBees Internal CD-347

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            abayer Andrew Bayer added a comment -

            Probably just XStream, yeah.

            abayer Andrew Bayer added a comment - Probably just XStream, yeah.
            jglick Jesse Glick added a comment -

            Any attempt to save a GString in XML (or, not shown here, pass it over Remoting) should be treated as a plugin bug.

            jglick Jesse Glick added a comment - Any attempt to save a GString in XML (or, not shown here, pass it over Remoting) should be treated as a plugin bug.
            oleg_nenashev Oleg Nenashev added a comment -

            I agree. JEP-200 will punish users of this class, I'd guess

            oleg_nenashev Oleg Nenashev added a comment - I agree. JEP-200 will punish users of this class, I'd guess
            antonyz Antony Zhong added a comment -

            I was one of customers being punished by JEP-200 too. Interestingly I have found a workaround like below. Basically, it seems to work fine when converting into String explicitly within the script.

             

            def retList = []
for (String s in aFunctionReturnsAGStringList()) {
   retList << s
}
retList

             

            antonyz Antony Zhong added a comment - I was one of customers being punished by JEP-200 too. Interestingly I have found a workaround like below. Basically, it seems to work fine when converting into String explicitly within the script.   def retList = [] for (String s in aFunctionReturnsAGStringList()) { retList << s } retList  
            oleg_nenashev Oleg Nenashev added a comment -

            yes, any conversion does the job

            oleg_nenashev Oleg Nenashev added a comment - yes, any conversion does the job

            People

              Unassigned Unassigned
              abayer Andrew Bayer
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: