Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42645

Search in Jenkins should be case insensitive by default

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Done
    • core
    • None
    • Jenkins 2.49

    Description

      As discussed on the mailing list [1] there seems to be consensus that case insensitive search in Jenkins is much more intuitive. This unfortunately is an opposite to the situation available in Jenkins as of this issue creation [2]. In a context of changes in JENKINS-40718 (and the same approach in other places) it would be no longer possible to find FAILED jobs just by typing "fail" ("FAIL" would be required). This is counterproductive and misleading.

      This issue assumes change the default behavior for newly crated users and for an anonymous user.

      In addition it would be good to consider (probably as a separate issue to do not postpone the main action) a possibility to change that behavior for users that haven't intentionally opt-in to have case sensitive search. Unfortunately it can be impossible to determine that situation. Therefore maybe it would be beneficial (to prevent a "regression" related to JENKINS-40718 and similar changes) to reset that behavior and require from an user to opt-in to it once more - however, it could be somehow clumsy in the implementation (e.g. two values in XML for the same feature). Suggestions for that are welcome.

       

      Attachments

        Activity

          emszpak Marcin Zajączkowski added a comment - Related PR: https://github.com/jenkinsci/jenkins/pull/2801

          Available in 2.50.

          emszpak Marcin Zajączkowski added a comment - Available in 2.50.

          Wrong issue... Should be JENKINS-40718.

          emszpak Marcin Zajączkowski added a comment - Wrong issue... Should be JENKINS-40718 .

          Code changed in jenkins
          User: Marcin Zajączkowski
          Path:
          core/src/main/java/hudson/search/FixedSet.java
          core/src/main/java/hudson/search/UserSearchProperty.java
          core/src/test/java/hudson/model/ViewTest.java
          core/src/test/java/jenkins/widgets/HistoryPageFilterTest.java
          test/src/test/java/jenkins/widgets/HistoryPageFilterCaseSensitiveSearchTest.java
          test/src/test/java/jenkins/widgets/HistoryPageFilterInsensitiveSearchTest.java
          http://jenkins-ci.org/commit/jenkins/b831acd9854b525d680ca72fd218c848121b9d3f
          Log:
          JENKINS-42645 Case insensitive search by default for new and anonymous users (#2801)

          String.equalsIgnoreCase is safer than toLowerCase when non English
          locales are used.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marcin Zajączkowski Path: core/src/main/java/hudson/search/FixedSet.java core/src/main/java/hudson/search/UserSearchProperty.java core/src/test/java/hudson/model/ViewTest.java core/src/test/java/jenkins/widgets/HistoryPageFilterTest.java test/src/test/java/jenkins/widgets/HistoryPageFilterCaseSensitiveSearchTest.java test/src/test/java/jenkins/widgets/HistoryPageFilterInsensitiveSearchTest.java http://jenkins-ci.org/commit/jenkins/b831acd9854b525d680ca72fd218c848121b9d3f Log: JENKINS-42645 Case insensitive search by default for new and anonymous users (#2801) JENKINS-42645 Case insensitive search by default JENKINS-42960 Search in FixedSet more locale friendly String.equalsIgnoreCase is safer than toLowerCase when non English locales are used. JENKINS-42645 Review remarks

          People

            emszpak Marcin Zajączkowski
            emszpak Marcin Zajączkowski
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: