• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: credentials-binding-plugin
• Labels:

  • diagnostics
• Environment:

  see attached about.html
  

1. about.html

   49 kB

   2017-03-31 09:50

[JENKINS-43264] NullPointerException when credentialsId is null

Cyril Jouve created issue - 2017-03-31 10:31

Cyril Jouve made changes - 2017-03-31 10:33

Description

Original: {{with the following:}} {{  steps \{}} {{    withCredentials([}} {{      string(credentialsId: params.GITHUB_PASSWORD, variable: 'GITHUB_PASSWORD'),}} {{      string(credentialsId: params.GITHUB_APP_SECRET, variable: 'GITHUB_APP_SECRET')}} {{   ]) \{}} {{ ansiblePlaybook(}}{{    .....}} {{ )}} {{ }}}   if param.GITHUB_PASSWORD is null (not defined), a NullPointerException is raised. The code in com.cloudbees.plugins.credentials.CredentialsProvider.findCredentialById should check for null value of id and provide a more useful message than a stacktrace.

New: {{with the following:}} {{   steps \{}} {{     withCredentials([}} {{       string(credentialsId: params.GITHUB_PASSWORD, variable: 'GITHUB_PASSWORD'),}} {{       string(credentialsId: params.GITHUB_APP_SECRET, variable: 'GITHUB_APP_SECRET')}} {{    ]) \{}} {{      ansiblePlaybook(    }}{{      }} {{        ...}} {{      )}} {{    }}} {{  }}}   if param.GITHUB_PASSWORD is null (not defined), a NullPointerException is raised. The code in com.cloudbees.plugins.credentials.CredentialsProvider.findCredentialById should check for null value of id and provide a more useful message than a stacktrace.

Stephen Connolly made changes - 2017-07-18 11:47

Component/s		New: credentials-binding-plugin [ 18129 ]
Component/s	Original: credentials-plugin [ 16523 ]

Stephen Connolly made changes - 2017-07-18 11:47

Assignee

Original: Stephen Connolly [ stephenconnolly ]

Collapse comment: Stephen Connolly added a comment - 2017-07-18 11:48

Stephen Connolly added a comment - 2017-07-18 11:48

https://github.com/jenkinsci/credentials-binding-plugin/blob/master/src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java#L224 credentials-binding plugin not credentials plugin

Expand comment: Stephen Connolly added a comment - 2017-07-18 11:48

Stephen Connolly added a comment - 2017-07-18 11:48 https://github.com/jenkinsci/credentials-binding-plugin/blob/master/src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java#L224  credentials-binding plugin not credentials plugin

Jesse Glick made changes - 2017-08-08 13:41

Summary

Original: NullPointerException when credentialid is not found

New: NullPointerException when credentialsId is null

Jesse Glick made changes - 2017-08-08 13:41

Labels

New: diagnostics

Collapse comment: Jesse Glick added a comment - 2018-03-19 13:36

Jesse Glick added a comment - 2018-03-19 13:36

This is a user error but MultiBinding.getCredentials could be improved to report it more clearly.

Expand comment: Jesse Glick added a comment - 2018-03-19 13:36

Jesse Glick added a comment - 2018-03-19 13:36 This is a user error but MultiBinding.getCredentials could be improved to report it more clearly.