Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44747

Queue locked indefinitely in ThrottleQueueTaskDispatcher.categoriesForPipeline

    XMLWordPrintable

Details

    Description

      See this thread dump. This call can block (for example while a Pipeline build is getting ready to resume), whereas this caller ought to return quickly (milliseconds, if at all possible).

      Observed in a Jenkins server after restarting with some running builds. Since all Queue calls hanged, the system seemed to be frozen—no branch indexing, etc. Even taking a fresh support bundle hanged for the same reason (probably support-core ought to interrupt component threads which do not finish within some fixed timeout). Cannot cancel running builds for the same reason. The only way to recover was to disable the TCB plugin.

      Have also heard a field report of a server running TCB 2.0 exhibiting similar symptoms, but have not yet confirmed duplicate, pending existence of a thread dump.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-44756 throttle(...) step can be ineffective at restart time

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link CloudBees Internal OSS-2306

          Web Link PR 50

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/hudson/plugins/throttleconcurrents/ThrottleJobProperty.java
            src/main/java/hudson/plugins/throttleconcurrents/ThrottleQueueTaskDispatcher.java
            http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/d105bb791364f3d8bfe42dcad448b14f9b0ed8b7
            Log:
            Merge pull request #50 from jglick/Queue-JENKINS-44747

            JENKINS-44747 Limit the amount of time categoriesForPipeline can run

            Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/7c61f6119c67...d105bb791364

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/hudson/plugins/throttleconcurrents/ThrottleJobProperty.java src/main/java/hudson/plugins/throttleconcurrents/ThrottleQueueTaskDispatcher.java http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/d105bb791364f3d8bfe42dcad448b14f9b0ed8b7 Log: Merge pull request #50 from jglick/Queue- JENKINS-44747 JENKINS-44747 Limit the amount of time categoriesForPipeline can run Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/7c61f6119c67...d105bb791364
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            README.md
            http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/fc9f6db53d21ebf50447e20a6304323ce62f6a46
            Log:
            Merge pull request #51 from jenkinsci/jenkins-44747-disclaimer

            Disclaimer for JENKINS-44747 change.

            Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/d105bb791364...fc9f6db53d21

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: README.md http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/fc9f6db53d21ebf50447e20a6304323ce62f6a46 Log: Merge pull request #51 from jenkinsci/jenkins-44747-disclaimer Disclaimer for JENKINS-44747 change. Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/d105bb791364...fc9f6db53d21
            abayer Andrew Bayer added a comment -

            Releasing as 2.0.1 as we speak.

            abayer Andrew Bayer added a comment - Releasing as 2.0.1 as we speak.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            CHANGELOG.md
            http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/080f4768bfd31d55c717f904c223bfb6119a89fe
            Log:
            [JENKINS-44756, JENKINS-44747] - 2.0.1 changelog + Errata notice

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: CHANGELOG.md http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/080f4768bfd31d55c717f904c223bfb6119a89fe Log: [JENKINS-44756, JENKINS-44747] - 2.0.1 changelog + Errata notice
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            CHANGELOG.md
            http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/d58cb2873a58ed59323b033aecd3c2536c569ad3
            Log:
            Merge pull request #52 from jenkinsci/changelog/2.0.1

            [JENKINS-44756, JENKINS-44747] - 2.0.1 changelog + Errata notice

            Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/cfc775b523fe...d58cb2873a58

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: CHANGELOG.md http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/d58cb2873a58ed59323b033aecd3c2536c569ad3 Log: Merge pull request #52 from jenkinsci/changelog/2.0.1 [JENKINS-44756, JENKINS-44747] - 2.0.1 changelog + Errata notice Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/cfc775b523fe...d58cb2873a58

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: