Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44891

Migrate SCMSource's id field to a @DataBoundSetter

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • scm-api-plugin
    • None

      Ease of use and form binding will do the right thing anyway with @DataBoundSetter

          [JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter

          Stephen Connolly created issue -
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Stephen Connolly made changes -
          Remote Link New: This issue links to "PR#41 (Web Link)" [ 17137 ]
          Stephen Connolly made changes -
          Epic Link New: JENKINS-43426 [ 180671 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/SCMSource.java
          src/main/java/jenkins/scm/impl/NullSCMSource.java
          src/main/java/jenkins/scm/impl/SingleSCMSource.java
          src/test/java/jenkins/scm/api/SCMRevisionActionTest.java
          src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java
          src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
          src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java
          src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java
          http://jenkins-ci.org/commit/scm-api-plugin/fc5c1941cc673ebcc7c357005789d3a557b011b3
          Log:
          [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/impl/NullSCMSource.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/test/java/jenkins/scm/api/SCMRevisionActionTest.java src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java http://jenkins-ci.org/commit/scm-api-plugin/fc5c1941cc673ebcc7c357005789d3a557b011b3 Log: [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
          http://jenkins-ci.org/commit/scm-api-plugin/9d15020884f2ab3f53525f3c7d72c864cfeb5dbc
          Log:
          JENKINS-44891 More tidy-up

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java http://jenkins-ci.org/commit/scm-api-plugin/9d15020884f2ab3f53525f3c7d72c864cfeb5dbc Log: JENKINS-44891 More tidy-up

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/SCMSource.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
          http://jenkins-ci.org/commit/scm-api-plugin/db4c72722f0af59f23463c3a74a399d7d720a2d3
          Log:
          JENKINS-44891 Address code review comments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java http://jenkins-ci.org/commit/scm-api-plugin/db4c72722f0af59f23463c3a74a399d7d720a2d3 Log: JENKINS-44891 Address code review comments

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/SCMSource.java
          src/main/java/jenkins/scm/impl/NullSCMSource.java
          src/main/java/jenkins/scm/impl/SingleSCMSource.java
          src/test/java/jenkins/scm/api/SCMRevisionActionTest.java
          src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java
          src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java
          src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
          src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java
          src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java
          http://jenkins-ci.org/commit/scm-api-plugin/4cf51ff512349b25021677158bdb018c6757f487
          Log:
          Merge pull request #41 from stephenc/jenkins-44891

          [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter

          Compare: https://github.com/jenkinsci/scm-api-plugin/compare/d13c2f27d5f4...4cf51ff51234

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/impl/NullSCMSource.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/test/java/jenkins/scm/api/SCMRevisionActionTest.java src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java http://jenkins-ci.org/commit/scm-api-plugin/4cf51ff512349b25021677158bdb018c6757f487 Log: Merge pull request #41 from stephenc/jenkins-44891 [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter Compare: https://github.com/jenkinsci/scm-api-plugin/compare/d13c2f27d5f4...4cf51ff51234

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/test/java/integration/BrandingTest.java
          src/test/java/integration/CategorizationTest.java
          src/test/java/integration/EnvironmentTest.java
          src/test/java/integration/EventsTest.java
          src/test/java/integration/ScmApiTest.java
          src/test/java/jenkins/branch/BranchNameContributorTest.java
          src/test/java/jenkins/branch/ParameterDefinitionBranchPropertyTest.java
          src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/bd430b60dbd52b7f6cf59d6e76f5faf31449aeed
          Log:
          JENKINS-43507 Pick up changes for JENKINS-44891

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/test/java/integration/BrandingTest.java src/test/java/integration/CategorizationTest.java src/test/java/integration/EnvironmentTest.java src/test/java/integration/EventsTest.java src/test/java/integration/ScmApiTest.java src/test/java/jenkins/branch/BranchNameContributorTest.java src/test/java/jenkins/branch/ParameterDefinitionBranchPropertyTest.java src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java http://jenkins-ci.org/commit/branch-api-plugin/bd430b60dbd52b7f6cf59d6e76f5faf31449aeed Log: JENKINS-43507 Pick up changes for JENKINS-44891

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: