Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44997

Restore Backup submission button does not work in Jenkins 1.609.3+

    XMLWordPrintable

Details

    Description

      Noticed it in my development environment. The plugin uses exotic table rendering, which effectively makes the submit button to appear outside the form. From what I see at some point the logic stopped handling it correctly.

      Attachments

        Activity

          Descending order - Click to sort in ascending order
          oleg_nenashev Oleg Nenashev added a comment -

          Released in 1.4

          oleg_nenashev Oleg Nenashev added a comment - Released in 1.4
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/periodicbackup/Util.java
          http://jenkins-ci.org/commit/periodicbackup-plugin/22ae79ae8fe8b372805ad55b8359a637257efa14
          Log:
          Fix regression in Util#listFiles() in config restoration.

          I was able to test it after the JENKINS-44997(https://issues.jenkins-ci.org/browse/JENKINS-44997) fix

          File#listFiles() returns empty list when the file does not exist.
          But in my case I was getting Error due to the isDirectory() check

          https://github.com/jenkinsci/periodicbackup-plugin/pull/10

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/periodicbackup/Util.java http://jenkins-ci.org/commit/periodicbackup-plugin/22ae79ae8fe8b372805ad55b8359a637257efa14 Log: Fix regression in Util#listFiles() in config restoration. I was able to test it after the JENKINS-44997 ( https://issues.jenkins-ci.org/browse/JENKINS-44997 ) fix File#listFiles() returns empty list when the file does not exist. But in my case I was getting Error due to the isDirectory() check https://github.com/jenkinsci/periodicbackup-plugin/pull/10
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/resources/org/jenkinsci/plugins/periodicbackup/PeriodicBackupLink/index.jelly
          http://jenkins-ci.org/commit/periodicbackup-plugin/9d2518869d9ecf161991ada284717c8a4853171c
          Log:
          Merge pull request #11 from jenkinsci/bug/JENKINS-44997

          JENKINS-44997 - Do not use table in BeriodicBackupLink submission form

          Compare: https://github.com/jenkinsci/periodicbackup-plugin/compare/7752b85dfb33...9d2518869d9e

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/resources/org/jenkinsci/plugins/periodicbackup/PeriodicBackupLink/index.jelly http://jenkins-ci.org/commit/periodicbackup-plugin/9d2518869d9ecf161991ada284717c8a4853171c Log: Merge pull request #11 from jenkinsci/bug/ JENKINS-44997 JENKINS-44997 - Do not use table in BeriodicBackupLink submission form Compare: https://github.com/jenkinsci/periodicbackup-plugin/compare/7752b85dfb33...9d2518869d9e
          oleg_nenashev Oleg Nenashev added a comment -

          https://github.com/jenkinsci/periodicbackup-plugin/pull/11

          oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/periodicbackup-plugin/pull/11
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/resources/org/jenkinsci/plugins/periodicbackup/PeriodicBackupLink/index.jelly
          http://jenkins-ci.org/commit/periodicbackup-plugin/1c2fe6b501b7f311a2a442500ca87f1c9e3c8f41
          Log:
          JENKINS-44997 - Do not use table in BeriodicBackupLink submission form

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/resources/org/jenkinsci/plugins/periodicbackup/PeriodicBackupLink/index.jelly http://jenkins-ci.org/commit/periodicbackup-plugin/1c2fe6b501b7f311a2a442500ca87f1c9e3c8f41 Log: JENKINS-44997 - Do not use table in BeriodicBackupLink submission form

          People

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: