[JENKINS-45815] Wrong ChangeSet Url for N+1 Repositories.

Type: Bug
Resolution: Not A Defect
Priority: Minor
Component/s: git-plugin
Labels:
- Git-plugin
- git
- git-plugin
- github
- jenkins
Environment:
Jenkins: 2.68
Git-Plugin: 3.41

Similar Issues:
Powered by SuggestiMate

Show

If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use GitHubProjectProperty value for URL when building change links.

Pipeline Example:

pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM', 
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'], 
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}

If I were to trigger a build by pushing a change to 'https://github.com/Organization/repo-two' then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

To clarify this still happens even if the repositories are broken into seperate SCM checkouts in a single pipeline. Issue is slightly mitigated by declaring the repository browser type on the individual checkouts.

This also occurs on non pipeline jobs as well.

Trevor Howard created issue - 2017-07-26 22:21

Trevor Howard made changes - 2017-07-26 22:36

Description

Original: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.secureserver.net/ECM/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.secureserver.net/ECM/repo-one/commit/<CommitId>' resulting in a 404.

New: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.secureserver.net/ECM/repo-one/commit/<CommitId>' resulting in a 404.

Trevor Howard made changes - 2017-07-26 22:37

Description

Original: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.secureserver.net/ECM/repo-one/commit/<CommitId>' resulting in a 404.

New: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

Mark Waite made changes - 2017-07-26 22:48

Assignee

Original: Mark Waite [ markewaite ]

Trevor Howard made changes - 2017-07-26 23:22

Description

Original: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

New: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

To clarify this still happens even if the repositories are broken into seperate SCM checkouts in a single pipeline. Issue is slightly mitigated by declaring the repository browser type on the individual checkouts.

This also occurs on non pipeline jobs as well.

Trevor Howard made changes - 2017-07-28 23:12

Comment

[ Would it make sense to store the remote origin URL in the generated changelog XML files or in another file that maps to the correct changelog file?

ChangeLogParser could read this value in and assign it as an attribute called projectUrl on generated ChangeLogSet that's separate from browser since this can be Null depending on the SCM configuration...

Looks like this stems from GithubProjectProperty only storing a single URL...

If a single pipeline job has multiple changLogSets stemming from multiple repositories then the GithubLinkAnnotator could resolve the actual URL from the change entry's parent by using the above proposed 'projectURL' attribute stored in anything extending ChangeLogSet. ]

Trevor Howard made changes - 2017-07-28 23:59

Description

Original: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use the first repository's browser URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

To clarify this still happens even if the repositories are broken into seperate SCM checkouts in a single pipeline. Issue is slightly mitigated by declaring the repository browser type on the individual checkouts.

This also occurs on non pipeline jobs as well.

New: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use GitHubProjectProperty value for URL when building change links if set.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

To clarify this still happens even if the repositories are broken into seperate SCM checkouts in a single pipeline. Issue is slightly mitigated by declaring the repository browser type on the individual checkouts.

This also occurs on non pipeline jobs as well.

Trevor Howard made changes - 2017-07-29 00:04

Description

Original: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use GitHubProjectProperty value for URL when building change links if set.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

To clarify this still happens even if the repositories are broken into seperate SCM checkouts in a single pipeline. Issue is slightly mitigated by declaring the repository browser type on the individual checkouts.

This also occurs on non pipeline jobs as well.

New: If a Git SCM checkout is configured with multiple repositories then all change sets for the build will use GitHubProjectProperty value for URL when building change links.

Pipeline Example:

{code:java}
pipeline {
    agent any

    stages {
        stage('Checkout'){
            steps {
                checkout(
                    [
                        $class: 'GitSCM',
                        branches: [[name: '*/master']],
                        doGenerateSubmoduleConfigurations: false,
                        extensions: [],
                        submoduleCfg: [],
                        userRemoteConfigs: [
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-one'],
                            [credentialsId: 'githubId', url: 'https://github.com/Organization/repo-two']
                        ]
                    ]
                )
            }
        }
    }
}{code}

If I were to trigger a build by pushing a change to '[https://github.com/Organization/repo-two'|https://github.secureserver.net/ECM/repo-two'] then the change set links would be 'https://github.com/Organization/repo-one/commit/<CommitId>' resulting in a 404.

To clarify this still happens even if the repositories are broken into seperate SCM checkouts in a single pipeline. Issue is slightly mitigated by declaring the repository browser type on the individual checkouts.

This also occurs on non pipeline jobs as well.

Trevor Howard made changes - 2017-07-29 00:04

Resolution		New: Not A Defect [ 7 ]
Status	Original: Open [ 1 ]	New: Closed [ 6 ]

Assignee:: Unassigned

Reporter:: Trevor Howard

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2017-07-26 22:21

Updated:: 2017-07-29 00:04

Resolved:: 2017-07-29 00:04

Jenkins

Details

Description

Attachments

Activity

People

Dates