[JENKINS-45909] UpstreamTrigger fails with NPE - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Blocker
Resolution: Fixed
Component/s: core
Labels:
- 2.73.1-fixed
Environment:
Jenkins 2.72

Similar Issues:

Show

Description

Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE.

To see the error, just create two "Pipeline" projects via Jenkins Web-UI:

First is named "Kevin", the script is:

pipeline {

  agent any

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Kevin here"
          }
      }
    }
  }

}

Starting this project works fine.

Now, second project is named "Chantalle", the script is:

pipeline {

  agent any

  triggers {
    upstream(
      threshold: hudson.model.Result.SUCCESS,
      upstreamProjects: "../Kevin"
    )
  }

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Chantalle here"
          }
      }
    }
  }

}

Similar, starting this project at its own works fine.

But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start:

Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
INFO: Kevin #6 completed: SUCCESS
Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
    at java.util.StringTokenizer.<init>(StringTokenizer.java:199)
    at java.util.StringTokenizer.<init>(StringTokenizer.java:221)
    at hudson.model.Items.fromNameList(Items.java:231)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966)
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Chantalle_config.xml
2 kB
2017-08-04 14:50
Kevin_config.xml
1 kB
2017-08-04 14:50

Issue Links

is related to

JENKINS-46161 Make ReverseBuildTrigger#getUpstreamProjects null-safe

Closed

links to

PR #2966

Activity

Ascending order - Click to sort in descending order

Stefan Gasterstädt created issue - 2017-08-01 13:48

Stefan Gasterstädt made changes - 2017-08-01 13:50

Field	Original Value	New Value
Description	Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE. To see the error, just create two "Pipeline" projects via Jenkins Web-UI: First is named "Kevin", the script is: {code:java} pipeline { agent any stages { stage("Hello") { steps { script { sh "echo Kevin here" } } } } } {code} Second is named "Chantalle", the script is: {code} pipeline { agent any triggers { upstream( threshold: hudson.model.Result.SUCCESS, upstreamProjects: "../Kevin" ) } stages { stage("Hello") { steps { script { sh "echo Chantalle here" } } } } } {code}	Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE. To see the error, just create two "Pipeline" projects via Jenkins Web-UI: First is named "Kevin", the script is: {code:java} pipeline { agent any stages { stage("Hello") { steps { script { sh "echo Kevin here" } } } } } {code} Starting this project works fine. Now, second project is named "Chantalle", the script is: {code} pipeline { agent any triggers { upstream( threshold: hudson.model.Result.SUCCESS, upstreamProjects: "../Kevin" ) } stages { stage("Hello") { steps { script { sh "echo Chantalle here" } } } } } {code} Again, starting this project works fine. But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start: {code} Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish INFO: Kevin #6 completed: SUCCESS Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report WARNING: RunListener failed java.lang.NullPointerException at java.util.StringTokenizer.<init>(StringTokenizer.java:199) at java.util.StringTokenizer.<init>(StringTokenizer.java:221) at hudson.model.Items.fromNameList(Items.java:231) at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256) at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279) at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211) at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663) at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134) at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966) at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407) at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35) at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112) at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code}

Stefan Gasterstädt made changes - 2017-08-01 13:52

Description

Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE.

To see the error, just create two "Pipeline" projects via Jenkins Web-UI:

First is named "Kevin", the script is:
{code:java}
pipeline {

  agent any

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Kevin here"
          }
      }
    }
  }

}
{code}

Starting this project works fine.

Now, second project is named "Chantalle", the script is:
{code}
pipeline {

  agent any

  triggers {
    upstream(
      threshold: hudson.model.Result.SUCCESS,
      upstreamProjects: "../Kevin"
    )
  }

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Chantalle here"
          }
      }
    }
  }

}
{code}

Again, starting this project works fine.

But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start:

{code}
Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
INFO: Kevin #6 completed: SUCCESS
Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
    at java.util.StringTokenizer.<init>(StringTokenizer.java:199)
    at java.util.StringTokenizer.<init>(StringTokenizer.java:221)
    at hudson.model.Items.fromNameList(Items.java:231)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966)
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
{code}

Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE.

To see the error, just create two "Pipeline" projects via Jenkins Web-UI:

First is named "Kevin", the script is:
{code:java}
pipeline {

  agent any

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Kevin here"
          }
      }
    }
  }

}
{code}

Starting this project works fine.

Now, second project is named "Chantalle", the script is:
{code}
pipeline {

  agent any

  triggers {
    upstream(
      threshold: hudson.model.Result.SUCCESS,
      upstreamProjects: "../Kevin"
    )
  }

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Chantalle here"
          }
      }
    }
  }

}
{code}

Similar, starting this project at its own works fine.

But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start:

{code}
Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
INFO: Kevin #6 completed: SUCCESS
Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
    at java.util.StringTokenizer.<init>(StringTokenizer.java:199)
    at java.util.StringTokenizer.<init>(StringTokenizer.java:221)
    at hudson.model.Items.fromNameList(Items.java:231)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966)
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
{code}

Stefan Gasterstädt made changes - 2017-08-04 08:35

Component/s

pipeline-model-definition-plugin [ 21706 ]

Andrew Bayer made changes - 2017-08-04 12:49

Assignee

Andrew Bayer [ abayer ]

Sir Tumbleweed made changes - 2017-08-04 14:50

Attachment		Chantalle_config.xml [ 39146 ]
Attachment		Kevin_config.xml [ 39147 ]

Andrew Bayer made changes - 2017-08-04 15:24

Component/s		core [ 15593 ]
Component/s	pipeline-model-definition-plugin [ 21706 ]
Component/s	workflow-job-plugin [ 21716 ]

Andrew Bayer made changes - 2017-08-04 15:25

Status

Open [ 1 ]

In Progress [ 3 ]

Andrew Bayer made changes - 2017-08-04 16:02

Status

In Progress [ 3 ]

In Review [ 10005 ]

Andrew Bayer made changes - 2017-08-04 16:02

Remote Link

This issue links to "PR #2966 (Web Link)" [ 17411 ]

Oleg Nenashev made changes - 2017-08-14 10:34

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

Oleg Nenashev made changes - 2017-08-14 10:34

Labels

lts-candidate

Oleg Nenashev made changes - 2017-08-14 10:34

Link

This issue is related to ~~JENKINS-46161~~ [ ~~JENKINS-46161~~ ]

Oliver Gondža made changes - 2017-09-04 13:51

Labels

lts-candidate

2.73.1-fixed

People

Assignee:: Andrew Bayer

Reporter:: Stefan Gasterstädt

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2017-08-01 13:48

Updated:: 2017-09-04 13:51

Resolved:: 2017-08-14 10:34