Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47016

Add "Build Started" comments attempt sometimes fails on Gerrit side

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • gerrit-trigger-plugin
    • None
    • gerrit-events-2.11.1
      gerrit-trigger: 2.26.0
      Jenkins: 2.73.1

    Description

      I have following setup:

      • Gerrit server 2.11.5
      • Jenkins server 2.73.1
      • Gerrit Trigger plugin 2.26.0

       

      A change in Gerrit triggers 3 jobs in my Jenkins server.

      Systematically, one of the 3  'Build Started' message cannot be posted properly to Gerrit.

      The Jenkins log file shows:

       

      SEVERE: Could not run command gerrit review 28149,1 --message 'Build Started https://jenkins.server/job/Check_Python_Scripts_Syntax/181/ (3/3)' --verified 0 --code-review 0 java.io.IOException: Error during sending command at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118) at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79) at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildStarted(GerritNotifier.java:88) at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildStartedCommandJob.run(BuildStartedCommandJob.java:80) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: Cannot post review one or more reviews failed; review output above (1) at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254) at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116) ... 8 more

      Attachments

        Issue Links

          Activity

            chantivlad chanti vlad created issue -
            chantivlad chanti vlad made changes -
            Field Original Value New Value
            Link This issue duplicates JENKINS-20808 [ JENKINS-20808 ]
            chantivlad chanti vlad made changes -
            Environment gerrit-events: 2.7.1
            gerrit-trigger: 2.14.0
            Jenkins: 1.580.1
            gerrit-trigger: 2.26.0
            Jenkins: 2.73.1
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            Priority Minor [ 4 ] Major [ 3 ]
            Summary CLONE - Add "Build Started" comments attempt sometimes fails on Gerrit side Add "Build Started" comments attempt sometimes fails on Gerrit side
            chantivlad chanti vlad made changes -
            Description Sometimes adding comments "Build Started" by gerrit-trigger-plugin from specific Jenkins server *more than 2 jobs running* to Gerrit server, fails.

            In case Jenkins has 2 jobs and these are triggered by uploaded patchset on gerrit,
            either "Build Started ... (1/2)" or "Build Started ... (2/2)" cannot be upload occasionally .


            Here is the stacktrace, issue happens in gerrit-events package :

            {code:java}
            java.io.IOException: Error during sending command
                    at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118)
                    at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79)
                    at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildStarted(GerritNotifier.java:88)
                    at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildStartedCommandJob.run(BuildStartedCommandJob.java:80)
                    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
                    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
                    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
                    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
                    at java.lang.Thread.run(Thread.java:745)
            Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: Cannot post review
            one or more reviews failed; review output above (1)
                    at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254)
                    at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116)
                    ... 8 more

            {code}

            In my investigation, It seems that *simultaneous attempt* of review gerrit's ssh commnd causes error:
            "_cannot post review_
            _one or more reviews failed; review output above_", these messages are defined/returned from Gerrit. https://code.google.com/p/gerrit/issues/detail?id=3730

            Issue may be in Gerrit side, but in the meantime, adding review comments of Gerrit ssh command to Gerrit server should take care for error (such as retrying) for Jenkins side.

            environment:

            gerrit-events :2.7.1
            gerrit-trigger:2.14.0
            I have following setup:
             * Gerrit server 2.11.5
             * Jenkins server 2.73.1
             * Gerrit Trigger plugin 2.26.0

             

            A change in Gerrit triggers 3 jobs in my Jenkins server.

            *Systematically*, one of the 3  'Build Started' message cannot be posted properly to Gerrit.

            The Jenkins log file shows:

             

            {{SEVERE: Could not run command gerrit review 28149,1 --message 'Build Started https://jenkins.server/job/Check_Python_Scripts_Syntax/181/ (3/3)' --verified 0 --code-review 0 java.io.IOException: Error during sending command at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118) at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79) at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildStarted(GerritNotifier.java:88) at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildStartedCommandJob.run(BuildStartedCommandJob.java:80) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: Cannot post review one or more reviews failed; review output above (1) at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254) at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116) ... 8 more}}
            chantivlad chanti vlad made changes -
            Environment gerrit-trigger: 2.26.0
            Jenkins: 2.73.1
            gerrit-events-2.11.1
            gerrit-trigger: 2.26.0
            Jenkins: 2.73.1

            People

              rsandell rsandell
              chantivlad chanti vlad
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: