-
Improvement
-
Resolution: Fixed
-
Major
-
None
-
Platform: All, OS: Windows XP
Currently -S is only used for log commands when there is a version tag
specified. I can't understand why it only does it in this case. I think it's
much more efficient to use -S in all cases.
Here is the code in ChangeLogTask. This gets executed on the slave.
I propose that the if() clause be removed and the whole block is always executed.
//whk why not do this in all cases?
if (getTag() != null) {
CvsVersion myCvsVersion = new CvsVersion();
myCvsVersion.setProject(getProject());
myCvsVersion.setTaskName("cvsversion");
myCvsVersion.setCvsRoot(getCvsRoot());
myCvsVersion.setCvsRsh(getCvsRsh());
myCvsVersion.setPassfile(getPassFile());
myCvsVersion.setDest(m_dir);
myCvsVersion.execute();
if (myCvsVersion.supportsCvsLogWithSOption())
}
I’ve been running with this change for a couple of days with different
master/slave configurations and windows clients.
This turns out to be pretty important when doing fresh checkouts. Our cvs
modules are so massive with so many revisions that on Windows the cvs command
completely falls over without the -S option.