Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-479

Use -S in CVS log

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: cvs-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: Windows XP
    • Similar Issues:

      Description

      Currently -S is only used for log commands when there is a version tag
      specified. I can't understand why it only does it in this case. I think it's
      much more efficient to use -S in all cases.

      Here is the code in ChangeLogTask. This gets executed on the slave.

      I propose that the if() clause be removed and the whole block is always executed.

      //whk why not do this in all cases?
      if (getTag() != null) {
      CvsVersion myCvsVersion = new CvsVersion();
      myCvsVersion.setProject(getProject());
      myCvsVersion.setTaskName("cvsversion");
      myCvsVersion.setCvsRoot(getCvsRoot());
      myCvsVersion.setCvsRsh(getCvsRsh());
      myCvsVersion.setPassfile(getPassFile());
      myCvsVersion.setDest(m_dir);
      myCvsVersion.execute();
      if (myCvsVersion.supportsCvsLogWithSOption())

      { addCommandArgument("-S"); }

      }

      I’ve been running with this change for a couple of days with different
      master/slave configurations and windows clients.

        Attachments

          Activity

          Hide
          bkayser bkayser added a comment -

          This turns out to be pretty important when doing fresh checkouts. Our cvs
          modules are so massive with so many revisions that on Windows the cvs command
          completely falls over without the -S option.

          Show
          bkayser bkayser added a comment - This turns out to be pretty important when doing fresh checkouts. Our cvs modules are so massive with so many revisions that on Windows the cvs command completely falls over without the -S option.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          Implemented in 1.105.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - Implemented in 1.105.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            bkayser bkayser
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: