Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47901

Remoting should not use File#toPath() due to the risk of unchecked exceptions

    XMLWordPrintable

Details

    Description

      subj, RuntimeException are evil

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/remoting/FileSystemJarCache.java
          src/main/java/hudson/remoting/Launcher.java
          src/main/java/hudson/remoting/Util.java
          src/main/java/hudson/remoting/jnlp/Main.java
          src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java
          src/main/java/org/jenkinsci/remoting/util/PathUtils.java
          http://jenkins-ci.org/commit/remoting/0549f75ae4f598cff08aebe9134ad4ba5ebf9ead
          Log:
          JENKINS-47901 - Stop using unchecked File#toPath()

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/FileSystemJarCache.java src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/Util.java src/main/java/hudson/remoting/jnlp/Main.java src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java src/main/java/org/jenkinsci/remoting/util/PathUtils.java http://jenkins-ci.org/commit/remoting/0549f75ae4f598cff08aebe9134ad4ba5ebf9ead Log: JENKINS-47901 - Stop using unchecked File#toPath()
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/remoting/FileSystemJarCache.java
          src/main/java/hudson/remoting/Launcher.java
          src/main/java/hudson/remoting/Util.java
          src/main/java/hudson/remoting/jnlp/Main.java
          src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java
          src/main/java/org/jenkinsci/remoting/util/PathUtils.java
          http://jenkins-ci.org/commit/remoting/7c28abe7f46dbb35a69d520b180efad11b763720
          Log:
          Merge pull request #211 from oleg-nenashev/bug/JENKINS-47901

          JENKINS-47901 - Stop using unchecked File#toPath()

          Compare: https://github.com/jenkinsci/remoting/compare/49c67eef8616...7c28abe7f46d

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/FileSystemJarCache.java src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/Util.java src/main/java/hudson/remoting/jnlp/Main.java src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java src/main/java/org/jenkinsci/remoting/util/PathUtils.java http://jenkins-ci.org/commit/remoting/7c28abe7f46dbb35a69d520b180efad11b763720 Log: Merge pull request #211 from oleg-nenashev/bug/ JENKINS-47901 JENKINS-47901 - Stop using unchecked File#toPath() Compare: https://github.com/jenkinsci/remoting/compare/49c67eef8616...7c28abe7f46d
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/bcd0b2c72bf8c55b7d4997e142954c149b7d4faa
          Log:
          Update Remoting from 3.13. to 3.14

          Fixes JENKINS-45294, JENKINS-47425, JENKINS-47901, JENKINS-47942 + about 50 reported FindBugs issues (JENKINS-37566). There are 13 FindBugs issues left, work in progress.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/bcd0b2c72bf8c55b7d4997e142954c149b7d4faa Log: Update Remoting from 3.13. to 3.14 Fixes JENKINS-45294 , JENKINS-47425 , JENKINS-47901 , JENKINS-47942 + about 50 reported FindBugs issues ( JENKINS-37566 ). There are 13 FindBugs issues left, work in progress.
          oleg_nenashev Oleg Nenashev added a comment -

          The patch has been released in Remoting 3.14 and integrated towards Jenkins 2.90

          oleg_nenashev Oleg Nenashev added a comment - The patch has been released in Remoting 3.14 and integrated towards Jenkins 2.90
          basil Basil Crow added a comment -

          Can this bug be marked as an LTS candidate?

          basil Basil Crow added a comment - Can this bug be marked as an LTS candidate?
          oleg_nenashev Oleg Nenashev added a comment -

          Sure. Just add the lts-candidate label and describe the reason

          oleg_nenashev Oleg Nenashev added a comment - Sure. Just add the lts-candidate label and describe the reason
          basil Basil Crow added a comment -

          I don't have a strong reason, but I have been seeing a lot of Remoting-related issues on 2.60.3 LTS. I rely heavily on the SSH Slaves and Swarm Plugins. I haven't had time to systematically debug them, but I saw that there has been a lot of activity fixing Remoting bugs (especially JENKINS-45294 and JENKINS-45023). So I want to try and upgrade to 2.73.x first and see if the issues are resolved before investigating further. Therefore it would be nice to see this in the next 2.73.x LTS release. No problem if it's too difficult, though.

          basil Basil Crow added a comment - I don't have a strong reason, but I have been seeing a lot of Remoting-related issues on 2.60.3 LTS. I rely heavily on the SSH Slaves and Swarm Plugins. I haven't had time to systematically debug them, but I saw that there has been a lot of activity fixing Remoting bugs (especially JENKINS-45294 and JENKINS-45023 ). So I want to try and upgrade to 2.73.x first and see if the issues are resolved before investigating further. Therefore it would be nice to see this in the next 2.73.x LTS release. No problem if it's too difficult, though.
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/94250ec1caae0ed6d3096e7002e0c2fd42c557e1
          Log:
          Update Remoting from 3.13. to 3.14

          Fixes JENKINS-45294, JENKINS-47425, JENKINS-47901, JENKINS-47942 + about 50 reported FindBugs issues (JENKINS-37566). There are 13 FindBugs issues left, work in progress.

          (cherry picked from commit bcd0b2c72bf8c55b7d4997e142954c149b7d4faa)

          Compare: https://github.com/jenkinsci/jenkins/compare/c624f66dc408...94250ec1caae

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/94250ec1caae0ed6d3096e7002e0c2fd42c557e1 Log: Update Remoting from 3.13. to 3.14 Fixes JENKINS-45294 , JENKINS-47425 , JENKINS-47901 , JENKINS-47942 + about 50 reported FindBugs issues ( JENKINS-37566 ). There are 13 FindBugs issues left, work in progress. (cherry picked from commit bcd0b2c72bf8c55b7d4997e142954c149b7d4faa) Compare: https://github.com/jenkinsci/jenkins/compare/c624f66dc408...94250ec1caae

          People

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: