Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48194

Binary compatibility broken in MsBuildBuilder

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • msbuild-plugin
    • None

      msbuild:1.28 breaks binary compatibility since a new parameter has been added to the constructor of the class MsBuildBuilder.

      Suggested actions
      1. Adding the previous constructor but marked as deprecated.
      2. Add a new test to check compatibility with previous configurations (configRoundTrip)

        1. ConsoleApp2.sln
          1 kB

          [JENKINS-48194] Binary compatibility broken in MsBuildBuilder

          Francisco Fernández created issue -
          Francisco Fernández made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Francisco Fernández made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Francisco Fernández made changes -
          Remote Link New: This issue links to "PR-35 (Web Link)" [ 18136 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal CLTS-2486 (Web Link)" [ 18970 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Francisco Javier Fernandez Gonzalez
          Path:
          src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
          src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
          src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip
          http://jenkins-ci.org/commit/msbuild-plugin/278ee8c5d9bd46d6b1d651f6d7e048e7eaf66eba
          Log:
          JENKINS-48194 Reverting binary incompatibility

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francisco Javier Fernandez Gonzalez Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip http://jenkins-ci.org/commit/msbuild-plugin/278ee8c5d9bd46d6b1d651f6d7e048e7eaf66eba Log: JENKINS-48194 Reverting binary incompatibility

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Francisco Javier Fernandez Gonzalez
          Path:
          src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip
          src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip
          http://jenkins-ci.org/commit/msbuild-plugin/e8e6341e97af1648002c3b1246e6e5c3009bcb27
          Log:
          [JENKINS-48194 Lighter configuration for LocalData

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francisco Javier Fernandez Gonzalez Path: src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip http://jenkins-ci.org/commit/msbuild-plugin/e8e6341e97af1648002c3b1246e6e5c3009bcb27 Log: [ JENKINS-48194 Lighter configuration for LocalData

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Francisco Javier Fernandez Gonzalez
          Path:
          src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
          http://jenkins-ci.org/commit/msbuild-plugin/f566e248dd59bfcbf3125f7eeda064da16b15c6b
          Log:
          JENKINS-48194 dummy commit

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francisco Javier Fernandez Gonzalez Path: src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java http://jenkins-ci.org/commit/msbuild-plugin/f566e248dd59bfcbf3125f7eeda064da16b15c6b Log: JENKINS-48194 dummy commit

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marshall777
          Path:
          src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
          src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
          src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip
          http://jenkins-ci.org/commit/msbuild-plugin/29e860368519926069225fc25dec0603a6c57e81
          Log:
          Merge pull request #35 from fcojfernandez/JENKINS-48194

          JENKINS-48194 Binary compatibility broken in MsBuildBuilder

          Compare: https://github.com/jenkinsci/msbuild-plugin/compare/a830f386f51b...29e860368519

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marshall777 Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip http://jenkins-ci.org/commit/msbuild-plugin/29e860368519926069225fc25dec0603a6c57e81 Log: Merge pull request #35 from fcojfernandez/ JENKINS-48194 JENKINS-48194 Binary compatibility broken in MsBuildBuilder Compare: https://github.com/jenkinsci/msbuild-plugin/compare/a830f386f51b...29e860368519

          Lionel Cabasson added a comment -

          Released in 1.29

          Lionel Cabasson added a comment - Released in 1.29
          Lionel Cabasson made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            fcojfernandez Francisco Fernández
            fcojfernandez Francisco Fernández
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: