Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48194

Binary compatibility broken in MsBuildBuilder

    XMLWordPrintable

Details

    Description

      msbuild:1.28 breaks binary compatibility since a new parameter has been added to the constructor of the class MsBuildBuilder.

      Suggested actions
      1. Adding the previous constructor but marked as deprecated.
      2. Add a new test to check compatibility with previous configurations (configRoundTrip)

      Attachments

        Issue Links

          links to

          Web Link CloudBees Internal CLTS-2486

          Web Link PR-35

          Activity

            Ascending order - Click to sort in descending order
            fcojfernandez Francisco Fernández created issue -
            fcojfernandez Francisco Fernández made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            fcojfernandez Francisco Fernández made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            fcojfernandez Francisco Fernández made changes -
            Remote Link This issue links to "PR-35 (Web Link)" [ 18136 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal CLTS-2486 (Web Link)" [ 18970 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Francisco Javier Fernandez Gonzalez
            Path:
            src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
            src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
            src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip
            http://jenkins-ci.org/commit/msbuild-plugin/278ee8c5d9bd46d6b1d651f6d7e048e7eaf66eba
            Log:
            JENKINS-48194 Reverting binary incompatibility

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francisco Javier Fernandez Gonzalez Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip http://jenkins-ci.org/commit/msbuild-plugin/278ee8c5d9bd46d6b1d651f6d7e048e7eaf66eba Log: JENKINS-48194 Reverting binary incompatibility
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Francisco Javier Fernandez Gonzalez
            Path:
            src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip
            src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip
            http://jenkins-ci.org/commit/msbuild-plugin/e8e6341e97af1648002c3b1246e6e5c3009bcb27
            Log:
            [JENKINS-48194 Lighter configuration for LocalData

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francisco Javier Fernandez Gonzalez Path: src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/newMsBuildBuilderTest.zip http://jenkins-ci.org/commit/msbuild-plugin/e8e6341e97af1648002c3b1246e6e5c3009bcb27 Log: [ JENKINS-48194 Lighter configuration for LocalData
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Francisco Javier Fernandez Gonzalez
            Path:
            src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
            http://jenkins-ci.org/commit/msbuild-plugin/f566e248dd59bfcbf3125f7eeda064da16b15c6b
            Log:
            JENKINS-48194 dummy commit

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francisco Javier Fernandez Gonzalez Path: src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java http://jenkins-ci.org/commit/msbuild-plugin/f566e248dd59bfcbf3125f7eeda064da16b15c6b Log: JENKINS-48194 dummy commit
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Marshall777
            Path:
            src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
            src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java
            src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip
            http://jenkins-ci.org/commit/msbuild-plugin/29e860368519926069225fc25dec0603a6c57e81
            Log:
            Merge pull request #35 from fcojfernandez/JENKINS-48194

            JENKINS-48194 Binary compatibility broken in MsBuildBuilder

            Compare: https://github.com/jenkinsci/msbuild-plugin/compare/a830f386f51b...29e860368519

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marshall777 Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java src/test/java/hudson/plugins/msbuild/MsBuildBuilderTest.java src/test/resources/hudson/plugins/msbuild/MsBuildBuilderTest/configRoundtrip.zip http://jenkins-ci.org/commit/msbuild-plugin/29e860368519926069225fc25dec0603a6c57e81 Log: Merge pull request #35 from fcojfernandez/ JENKINS-48194 JENKINS-48194 Binary compatibility broken in MsBuildBuilder Compare: https://github.com/jenkinsci/msbuild-plugin/compare/a830f386f51b...29e860368519
            marshall777 Lionel Cabasson added a comment -

            Released in 1.29

            marshall777 Lionel Cabasson added a comment - Released in 1.29
            marshall777 Lionel Cabasson made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            kishore_minuscule Kishore Kumar made changes -
            Attachment ConsoleApp2.sln [ 43959 ]

            People

              fcojfernandez Francisco Fernández
              fcojfernandez Francisco Fernández
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: