Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48618

SSH Slaves should pass read timeout to TrileadSSH and gracefully handle it in the logic

    XMLWordPrintable

Details

    • New Feature
    • Resolution: Fixed
    • Minor
    • ssh-slaves-plugin
    • None
    • trilead-ssh2-build-217-jenkins-16 ssh-slaves-1.31.1

    Description

      Read operations may hang infinitely in the current implementation, and we would be interested to add a Read timeout when creating Trilead SSH connections.

      "SSHLauncher.launch for 'myagent' node [#1]" #2565 prio=5 os_prio=0 tid=0x00007f080c1b1000 nid=0x35c runnable [0x00007f07b2c5c000]
   java.lang.Thread.State: RUNNABLE
    at java.net.SocketInputStream.socketRead0(Native Method)
    at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
    at java.net.SocketInputStream.read(SocketInputStream.java:171)
    at java.net.SocketInputStream.read(SocketInputStream.java:141)
    at java.net.SocketInputStream.read(SocketInputStream.java:224)
    at com.trilead.ssh2.transport.ClientServerHello.readLineRN(ClientServerHello.java:31)
    at com.trilead.ssh2.transport.ClientServerHello.<init>(ClientServerHello.java:68)
    at com.trilead.ssh2.transport.TransportManager.initialize(TransportManager.java:487)
    at com.trilead.ssh2.Connection.connect(Connection.java:774)
    - locked <0x0000000594003de0> (a com.trilead.ssh2.Connection)
    at com.trilead.ssh2.Connection.connect(Connection.java:703)
    - locked <0x0000000594003de0> (a com.trilead.ssh2.Connection)
    at com.trilead.ssh2.Connection.connect(Connection.java:617)
    - locked <0x0000000594003de0> (a com.trilead.ssh2.Connection)
    at hudson.plugins.sshslaves.SSHLauncher.openConnection(SSHLauncher.java:1302)
    at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:814)
    at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:803)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:748)

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48616 SSH Slaves should pass connection timeout to connection.connect() if there is an agent startup timeout

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-48617 SSH Slaves should ALWAYS pass connection timeout to connection.connect()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-58589 Re-make the retry connection process

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link PR

          Activity

            People

              ifernandezcalvo Ivan Fernandez Calvo
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: