Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48766

Jenkins Core should provide info about minimum supported Remoting version in API/REST API/logs

    XMLWordPrintable

Details

    • New Feature
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • None

    Description

      It is a follow-up to JENKINS-48761. Currently Jenkins Core does not specify a minimal-supported version, so users do not even got warnings when they use old Remoting versions without using a Version Column plugin (CC batmat)

      I propose to enhance the behavior:

      • Define a minimal supported version within the core
      • Where to return the data?
        • Make the version available via Jenkins API
        • The minimal supported version should be returned in TcpAgentListener's headers so that Agent can process it on its side
        • Nice2Have: The minimal supported version should returned in the Jenkins WAR Manifest
      • Diagnostics:
        • Warning in agent connection log when the version older than the Minimal one is connected. The connection whould not be aborted, user should just know he runs in YOLO mode
        • Warning in the log on the Remoting side (separate ticket - TODO)
        • Nice2Have: Warning on the agent main page
        • Nice2Have: Administrative monitor OR support in Version Column Plugin
        • Nice2Have: Warning in the Support Core plugin

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48761 Jenkins Agents do not connect after update from version 2.95 to version 2.99 and jobs fail

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48754 Jenkins Slaves do not connect after update from version 2.95 to version 2.99

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved
          relates to

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-50211 Reject connections from agents with unsupported Remoting versions

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-50095 Remoting should check the "Remoting-Minimum-Version" header when connecting to the master

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link https://github.com/jenkinsci/jenkins/pull/3212

          Web Link https://github.com/jenkinsci/jenkins/pull/3250

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/filter/resources/jenkins/slaves/remoting-info.properties
            core/src/main/java/hudson/TcpSlaveAgentListener.java
            core/src/main/java/jenkins/slaves/RemotingVersionInfo.java
            core/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java
            pom.xml
            http://jenkins-ci.org/commit/jenkins/6d44f7e080aed5c4a59f201e1968f97d679e47e2
            Log:
            JENKINS-48766 - Create restricted API for getting info about Remoting versions

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/filter/resources/jenkins/slaves/remoting-info.properties core/src/main/java/hudson/TcpSlaveAgentListener.java core/src/main/java/jenkins/slaves/RemotingVersionInfo.java core/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java pom.xml http://jenkins-ci.org/commit/jenkins/6d44f7e080aed5c4a59f201e1968f97d679e47e2 Log: JENKINS-48766 - Create restricted API for getting info about Remoting versions
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/jenkins/MasterToSlaveFileCallable.java
            core/src/main/java/jenkins/security/MasterToSlaveCallable.java
            core/src/main/java/jenkins/slaves/RemotingVersionInfo.java
            http://jenkins-ci.org/commit/jenkins/0ca85720d44f71315fdca2723b758ff8711771fc
            Log:
            JENKINS-48766 - Make the RemotingVersionInfo API publicly available

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/MasterToSlaveFileCallable.java core/src/main/java/jenkins/security/MasterToSlaveCallable.java core/src/main/java/jenkins/slaves/RemotingVersionInfo.java http://jenkins-ci.org/commit/jenkins/0ca85720d44f71315fdca2723b758ff8711771fc Log: JENKINS-48766 - Make the RemotingVersionInfo API publicly available
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/TcpSlaveAgentListener.java
            http://jenkins-ci.org/commit/jenkins/1b2f0e7e64dc32bc6aac8d31b35013f52a668613
            Log:
            JENKINS-48766 - Expose Remoting Minimum version in TcpSlaveAgentListener

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/1b2f0e7e64dc32bc6aac8d31b35013f52a668613 Log: JENKINS-48766 - Expose Remoting Minimum version in TcpSlaveAgentListener
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/slaves/SlaveComputer.java
            http://jenkins-ci.org/commit/jenkins/95f1f5ad19385408da15eb1b4dcaedb705dee638
            Log:
            JENKINS-48766 - Print warnings in agent connection logs when the Remoting version is not supported

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/95f1f5ad19385408da15eb1b4dcaedb705dee638 Log: JENKINS-48766 - Print warnings in agent connection logs when the Remoting version is not supported
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            test/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/07d8f4e3e6715a3ea5b060709a92a6b6950aca30
            Log:
            JENKINS-48766 - Add info about remoting to the WAR manifest file

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: test/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java war/pom.xml http://jenkins-ci.org/commit/jenkins/07d8f4e3e6715a3ea5b060709a92a6b6950aca30 Log: JENKINS-48766 - Add info about remoting to the WAR manifest file
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/TcpSlaveAgentListener.java
            core/src/main/java/hudson/slaves/SlaveComputer.java
            core/src/main/java/jenkins/MasterToSlaveFileCallable.java
            core/src/main/java/jenkins/security/MasterToSlaveCallable.java
            core/src/main/java/jenkins/slaves/RemotingVersionInfo.java
            test/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/dbc75125c565905a9c07b0c83d6ae71b2681c67f
            Log:
            Merge pull request #3250 from oleg-nenashev/feature/JENKINS-48766-minimum-remoting-version

            JENKINS-48766 - Expose information about Remoting versions via API

            Compare: https://github.com/jenkinsci/jenkins/compare/73e2c9fb8f08...dbc75125c565

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/TcpSlaveAgentListener.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/jenkins/MasterToSlaveFileCallable.java core/src/main/java/jenkins/security/MasterToSlaveCallable.java core/src/main/java/jenkins/slaves/RemotingVersionInfo.java test/src/test/java/jenkins/slaves/RemotingVersionInfoTest.java war/pom.xml http://jenkins-ci.org/commit/jenkins/dbc75125c565905a9c07b0c83d6ae71b2681c67f Log: Merge pull request #3250 from oleg-nenashev/feature/ JENKINS-48766 -minimum-remoting-version JENKINS-48766 - Expose information about Remoting versions via API Compare: https://github.com/jenkinsci/jenkins/compare/73e2c9fb8f08...dbc75125c565
            oleg_nenashev Oleg Nenashev added a comment -

            The feature has been delivered in 2.104

            oleg_nenashev Oleg Nenashev added a comment - The feature has been delivered in 2.104

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: