Details
-
Bug
-
Status: In Review (View Workflow)
-
Minor
-
Resolution: Unresolved
-
None
Description
As a user of pipeline input step, if I am an admin I should be able to approve any pipeline, period – I could rewrite the pipeline entirely, so there's no point blocking this, and the ApproverAction will show that I bypassed any approvers list.
Attachments
Issue Links
- causes
-
JENKINS-56016 Input step submitter parameter is ignored for administrators
-
- Closed
-
- links to
Code changed in jenkins
User: Sam Van Oort
Path:
src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java
http://jenkins-ci.org/commit/pipeline-input-step-plugin/d555bb4c87b7ace5881d91a4880543b5f7e4568f
Log:
Merge pull request #20 from svanoort/admin-can-approve-JENKINS-48998
Fix JENKINS-48998 by ensuring admins can always approve
Compare: https://github.com/jenkinsci/pipeline-input-step-plugin/compare/7aea2abf4864...d555bb4c87b7