Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48998

Can't approve pipeline input step to proceed even when a global admin

XMLWordPrintable

      As a user of pipeline input step, if I am an admin I should be able to approve any pipeline, period – I could rewrite the pipeline entirely, so there's no point blocking this, and the ApproverAction will show that I bypassed any approvers list.

          [JENKINS-48998] Can't approve pipeline input step to proceed even when a global admin

          Sam Van Oort created issue -
          Sam Van Oort made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Sam Van Oort made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Sam Van Oort made changes -
          Remote Link New: This issue links to "PR #20 (Web Link)" [ 19871 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java
          http://jenkins-ci.org/commit/pipeline-input-step-plugin/6448d8c8dce70064a0b6792e541c3a7edd099486
          Log:
          Fix JENKINS-48998 by ensuring admins can always approve

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/6448d8c8dce70064a0b6792e541c3a7edd099486 Log: Fix JENKINS-48998 by ensuring admins can always approve

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java
          http://jenkins-ci.org/commit/pipeline-input-step-plugin/d555bb4c87b7ace5881d91a4880543b5f7e4568f
          Log:
          Merge pull request #20 from svanoort/admin-can-approve-JENKINS-48998

          Fix JENKINS-48998 by ensuring admins can always approve

          Compare: https://github.com/jenkinsci/pipeline-input-step-plugin/compare/7aea2abf4864...d555bb4c87b7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/d555bb4c87b7ace5881d91a4880543b5f7e4568f Log: Merge pull request #20 from svanoort/admin-can-approve- JENKINS-48998 Fix JENKINS-48998 by ensuring admins can always approve Compare: https://github.com/jenkinsci/pipeline-input-step-plugin/compare/7aea2abf4864...d555bb4c87b7
          Devin Nusbaum made changes -
          Link New: This issue causes JENKINS-56016 [ JENKINS-56016 ]
          Mark Waite made changes -
          Released As New: https://github.com/jenkinsci/pipeline-input-step-plugin/releases/tag/pipeline-input-step-2.9
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            svanoort Sam Van Oort
            svanoort Sam Van Oort
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: