Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49050

I can view my sequential declarative pipeline stages in the pipeline visualization plugin

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • Blue Ocean 1.8.0

      For Declarative 1.3 (JENKINS-46809), we're adding support for sequential groups of stages, either as part of a set of parallel stages or on its own in a top-level stage. I won't bother going into all the rationale behind it. =) See the Declarative PR for the relevant changes, examples, discussion, etc.

      This will require changes for both visualization and the editor:

      • Visualization - see my pathetic attempts at mockups attached here. jamesdumay probably will come up with something better in like five seconds. =)
      • Editor - Should be something like we have for parallel stages - reordering would be good too.

        1. image-2018-09-13-14-31-36-029.png
          image-2018-09-13-14-31-36-029.png
          11 kB
        2. proof.png
          proof.png
          39 kB
        3. image-2018-08-07-20-14-01-469.png
          image-2018-08-07-20-14-01-469.png
          20 kB
        4. sequential-group-parallel.png
          sequential-group-parallel.png
          87 kB
        5. sequential-group-top-level.png
          sequential-group-top-level.png
          82 kB

          [JENKINS-49050] I can view my sequential declarative pipeline stages in the pipeline visualization plugin

          Andrew Bayer created issue -
          Andrew Bayer made changes -
          Link New: This issue relates to JENKINS-46809 [ JENKINS-46809 ]
          James Dumay made changes -
          Epic Link New: JENKINS-36291 [ 172300 ]

          Michael Neale added a comment -

          hey sophistifunk any guesses on how much work this would be for both vis and editor? 

          Michael Neale added a comment - hey sophistifunk any guesses on how much work this would be for both vis and editor? 

          Josh McDonald added a comment -

          Renderer: zero for multi-stage-parallels, as that's already done. As for "grouping" at the top level, it's mostly about cooking up a sensible visual language rather than layout changes.

           

          Editor-wise, I'm not sure. We need to replace the editor's mixed-in layout code with the renderer layout class, which was extracted from the renderer for this purpose and should be done either way.

           

          Also, we would need changes to the `PipelineNodeGraphVisitor` to support it. I have ideas about refactoring that to make it less... intimidating... to change, but I'll need to run them by Vivek and probably a few people on pipeline to make sure I'm not talking out of my ass

          Josh McDonald added a comment - Renderer: zero for multi-stage-parallels, as that's already done. As for "grouping" at the top level, it's mostly about cooking up a sensible visual language rather than layout changes.   Editor-wise, I'm not sure. We need to replace the editor's mixed-in layout code with the renderer layout class, which was extracted from the renderer for this purpose and should be done either way.   Also, we would need changes to the `PipelineNodeGraphVisitor` to support it. I have ideas about refactoring that to make it less... intimidating... to change, but I'll need to run them by Vivek and probably a few people on pipeline to make sure I'm not talking out of my ass

          Michael Neale added a comment -

          thanks sophistifunk - so it sounds like "not a small thing" 

          Michael Neale added a comment - thanks sophistifunk - so it sounds like "not a small thing" 
          Vivek Pandey made changes -
          Link New: This issue is blocked by JENKINS-49779 [ JENKINS-49779 ]

          Vivek Pandey added a comment -

          Yeah we need changes in nodes  API, opened this ticket: https://issues.jenkins-ci.org/browse/JENKINS-49779.

          Vivek Pandey added a comment - Yeah we need changes in nodes  API, opened this ticket:  https://issues.jenkins-ci.org/browse/JENKINS-49779 .
          Vivek Pandey made changes -
          Sprint New: Pipeline - Candidates [ 381 ]
          Vivek Pandey made changes -
          Sprint Original: Pipeline - Candidates [ 381 ]

            nicu Nicolae Pascu
            abayer Andrew Bayer
            Votes:
            18 Vote for this issue
            Watchers:
            40 Start watching this issue

              Created:
              Updated:
              Resolved: