Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4920

i18n and l10n(ja) for cobertura plugin

    XMLWordPrintable

Details

    • Patch
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • cobertura-plugin
    • None
    • Platform: All, OS: All

    Description

      Hi,

      I've internationalized cobertura plugin and localized it to Japanese.
      See attached patch.
      If it's permitted, I'd like to commit them.

      Thanks.

      Attachments

        Activity

          Code changed in hudson
          User: : sogabe
          Path:
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaBuildAction.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaCoverageParser.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaProjectAction.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaPublisher.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/MavenCoberturaAggregatedReport.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/MavenCoberturaPublisher.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/CoverageElement.java
          trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/CoverageMetric.java
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/floatingBox.jelly
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/floatingBox_ja.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/nodata.jelly
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/nodata.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/nodata_ja.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaPublisher/config.jelly
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaPublisher/config.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaPublisher/config_ja.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/Messages.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/Messages_ja.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/CoverageResult/index.jelly
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/CoverageResult/index.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/CoverageResult/index_ja.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/Messages.properties
          trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/Messages_ja.properties
          trunk/hudson/plugins/cobertura/src/test/java/hudson/plugins/cobertura/CoberturaCoverageParserTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=24834
          Log:
          [FIXED JENKINS-4920] i18n and l10n(ja) for cobertura plugin.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : sogabe Path: trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaBuildAction.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaCoverageParser.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaProjectAction.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/CoberturaPublisher.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/MavenCoberturaAggregatedReport.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/MavenCoberturaPublisher.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/CoverageElement.java trunk/hudson/plugins/cobertura/src/main/java/hudson/plugins/cobertura/targets/CoverageMetric.java trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/floatingBox.jelly trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/floatingBox_ja.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/nodata.jelly trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/nodata.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaProjectAction/nodata_ja.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaPublisher/config.jelly trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaPublisher/config.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/CoberturaPublisher/config_ja.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/Messages.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/Messages_ja.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/CoverageResult/index.jelly trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/CoverageResult/index.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/CoverageResult/index_ja.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/Messages.properties trunk/hudson/plugins/cobertura/src/main/resources/hudson/plugins/cobertura/targets/Messages_ja.properties trunk/hudson/plugins/cobertura/src/test/java/hudson/plugins/cobertura/CoberturaCoverageParserTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=24834 Log: [FIXED JENKINS-4920] i18n and l10n(ja) for cobertura plugin.

          Sogabe-san, with a long commit history like yours, I don't think you need to seek an explicit approval from the plugin owner like this — please feel free to just commit directly. If anyone complains, you can tell them to blame me.

          kohsuke Kohsuke Kawaguchi added a comment - Sogabe-san, with a long commit history like yours, I don't think you need to seek an explicit approval from the plugin owner like this — please feel free to just commit directly. If anyone complains, you can tell them to blame me.
          sogabe sogabe added a comment -

          Hi mindless, Thanks for your reply and review.
          I'm going to fix patch and commit next weekend.

          Thanks!

          sogabe sogabe added a comment - Hi mindless, Thanks for your reply and review. I'm going to fix patch and commit next weekend. Thanks!
          mindless Alan Harder added a comment -

          I don't maintain this plugin, but I reviewed the patch and it looks OK to me to commit.. couple minor comments:

          • in CoberturaPublisher you have "Messages.MavenCoberturaPublisher_displayName()" instead of "CoberturaPublisher_displayName()" (same content, but should match the class it is in..)
          • in config.properties the image tags should end in /> instead of just >

          Thanks!

          mindless Alan Harder added a comment - I don't maintain this plugin, but I reviewed the patch and it looks OK to me to commit.. couple minor comments: in CoberturaPublisher you have "Messages.MavenCoberturaPublisher_displayName()" instead of "CoberturaPublisher_displayName()" (same content, but should match the class it is in..) in config.properties the image tags should end in /> instead of just > Thanks!
          sogabe sogabe added a comment -

          Created an attachment (id=1031)
          i18n and l10n

          sogabe sogabe added a comment - Created an attachment (id=1031) i18n and l10n

          People

            stephenconnolly Stephen Connolly
            sogabe sogabe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: