[JENKINS-49328] MultiJob has a forbidden nested reference to a model object - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Component/s: multijob-plugin
Labels:
None
Environment:
multijob:1.28
core:2.89.3

Similar Issues:

Show

Description

When running a simple, the Jenkins logs show the following WARNINGS:

Feb 02, 2018 9:47:26 AM hudson.XmlFile replaceIfNotAtTopLevel
WARNING: JENKINS-45892: reference to job1 #2 being saved from unexpected /tmp/Jenkins/jobs/testSimpleMutliJob/builds/2/build.xml
java.lang.IllegalStateException
	at hudson.XmlFile.replaceIfNotAtTopLevel(XmlFile.java:210)
	at hudson.model.Run.writeReplace(Run.java:1929)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteReplace(SerializationMethodInvoker.java:89)
	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:141)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
	at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
	at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
	at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
	at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
	at hudson.XmlFile.write(XmlFile.java:181)
	at hudson.model.Run.save(Run.java:1920)
	at hudson.model.Run.execute(Run.java:1781)
	at com.tikal.jenkins.plugins.multijob.MultiJobBuild.run(MultiJobBuild.java:73)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:421)

How to Reproduce

Create a simple job that does nothing
Create a simple MultiJob project with one phase, which contains the reference to the job, see multijob-config.png
Build the MultiJob

You will see the stacktrace appearing several times (3 times), see logs-after-build.log

Impact

This is critical as when many jobs run at the same time, it is polluting at such extent that it slow down the Jenkins server and make it unresponsive.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

logs-after-build.log
13 kB
2018-02-01 23:53
multijob-config.png
48 kB
2018-02-01 23:53

Issue Links

blocks

JENKINS-30906 MultiJobBuild.SubBuild does not contain full job name (if using folders)

Resolved

relates to

JENKINS-48685 Deadlock when running a Multijob with multiple slaves

Resolved

JENKINS-45892 Forbid nested references to model objects

Resolved

links to

PR 129

PR#128

Activity

Ascending order - Click to sort in descending order

Allan BURDAJEWICZ created issue - 2018-02-02 00:00

Allan BURDAJEWICZ made changes - 2018-02-02 00:02

Field	Original Value	New Value
Assignee		Allan BURDAJEWICZ [ allan_burdajewicz ]

Allan BURDAJEWICZ made changes - 2018-02-02 00:13

Status

Open [ 1 ]

In Progress [ 3 ]

Allan BURDAJEWICZ made changes - 2018-02-02 00:13

Remote Link

This issue links to "PR#128 (Web Link)" [ 20005 ]

Allan BURDAJEWICZ made changes - 2018-02-02 00:17

Summary

MultiJob has a forbidden nest reference reference to a model object

MultiJob has a forbidden nested reference reference to a model object

Allan BURDAJEWICZ made changes - 2018-02-02 00:17

Summary

MultiJob has a forbidden nested reference reference to a model object

MultiJob has a forbidden nested reference to a model object

Allan BURDAJEWICZ made changes - 2018-02-02 00:45

Status

In Progress [ 3 ]

In Review [ 10005 ]

Allan BURDAJEWICZ made changes - 2018-02-02 03:02

Link

This issue relates to ~~JENKINS-48685~~ [ ~~JENKINS-48685~~ ]

Allan BURDAJEWICZ made changes - 2018-02-02 03:02

Link

This issue relates to ~~JENKINS-45892~~ [ ~~JENKINS-45892~~ ]

Jesse Glick made changes - 2018-02-02 10:05

Link

This issue blocks ~~JENKINS-30906~~ [ ~~JENKINS-30906~~ ]

Jesse Glick made changes - 2018-02-02 10:32

Assignee

Allan BURDAJEWICZ [ allan_burdajewicz ]

Jesse Glick [ jglick ]

Jesse Glick made changes - 2018-02-02 10:32

Status

In Review [ 10005 ]

In Progress [ 3 ]

Jesse Glick made changes - 2018-02-02 10:38

Remote Link

This issue links to "PR 129 (Web Link)" [ 20007 ]

Jesse Glick made changes - 2018-02-02 10:38

Status

In Progress [ 3 ]

In Review [ 10005 ]

Chris Lombardo made changes - 2018-02-23 01:39

Comment

[ This issue just started for me as well. To the best of my knowledge no plugin/Jenkins changes were made between my last successful build and when my issue and the tracebacks began.

multijob ver. 1.28 / Jenkins ver. 2.108 / openjdk version "1.8.0_151"

End result is phase 2 job doesn't run due to "Condition was evaluated to false." though all phase 1 jobs completed successfully. Job execution is sequential and continuation condition is "Successful".
{noformat}
Finished Build : #68 of Job : S****ot -- build package with status : SUCCESS
Finished Build : #62 of Job : S****ot -- build server container with status : SUCCESS
Finished Build : #63 of Job : S****ot -- Sanity test with status : SUCCESS
Skipping S****ot -- pull TAG, tag as latest, push. Condition was evaluated to false.
{noformat}
I see the following trace at each phase 1 job run.
{noformat}
Feb 22, 2018 6:11:00 PM hudson.XmlFile replaceIfNotAtTopLevel
WARNING: ~~JENKINS-45892~~: reference to S****ot -- Sanity test #63 being saved from unexpected /repo/lib/jenkins/jobs/S****ot/jobs/S****ot -- build, test, deploy multijob/builds/65/build.xml
java.lang.IllegalStateException
at hudson.XmlFile.replaceIfNotAtTopLevel(XmlFile.java:222)
at hudson.model.Run.writeReplace(Run.java:1932)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteReplace(SerializationMethodInvoker.java:89)
at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:141)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
at hudson.XmlFile.write(XmlFile.java:193)
at hudson.model.Run.save(Run.java:1923)
at hudson.model.Run.execute(Run.java:1784)
at com.tikal.jenkins.plugins.multijob.MultiJobBuild.run(MultiJobBuild.java:73)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
{noformat} ]

Chen Cohen made changes - 2018-03-01 12:33

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Closed [ 6 ]

People

Assignee:: Jesse Glick

Reporter:: Allan BURDAJEWICZ

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2018-02-02 00:00

Updated:: 2018-03-01 12:33

Resolved:: 2018-03-01 12:33