Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45892

Forbid nested references to model objects

    XMLWordPrintable

Details

    Description

      Some model objects which are written at top level to their own XML file. The most important examples are AbstractItem, Run, and User.

      Sometimes various classes defined in Jenkins which are intended to be serialized via XStream will mistakenly declare a non-transient field referring back to the model object. If the class happens to be an action, property, etc. which is contained in that same model object, this will usually be harmless, as XStream will create a reference—though it will occasionally blow up in your face when using lazy loading of builds, since there are conditions under which a fresh copy of the model object will be written, which will typically be in some inconsistent state after deserialization since no onLoad method has been called on it. If the class is contained in something else, you will definitely get duplicated data, which can be rather bad.

      Jenkins should if possible block you from accidentally storing a model object inside something else.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-47158 Warnings about workflow/*-parallel-synthetic.xml serializing WorkflowRun objects

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-49368 Last Changes causes the JENKINS-45892

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18809 Discard Unreadable Data results in an NPE

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-17125 FingerprintAction deserialization leads to NPE

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20950 NPE during Discard Old Data

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-45846 NullPointerException in hudson.plugins.analysis.core.BuildResult

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48322 BlueOceanUrlObjectImpl has a non-transient reference to a ModelObject

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-50273 Cucumber Living Documentation nests project references in Build actions

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-49328 MultiJob has a forbidden nested reference to a model object

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-52296 DependencyGraph persistence make jobs unreadable

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          links to

          Web Link CloudBees Internal OSS-2422

          Web Link CloudBees Internal TIGER-3963

          Web Link CloudBees Internal TIGER-3964

          Web Link CloudBees Internal TIGER-3986

          Web Link core PR 2957

          Web Link PR 2997

          Web Link XStream object graphs

          mentioned in

          Page Loading...

          Activity

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              23 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: