Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
Follow-up to the message from amuniz. On Remoting hosts with multiple channels it would be great to have a name of the channel (OR IP/whatever of the client connection) if the message is corrupted.
Current message sample:
WARNING: Failed to construct Command
java.io.StreamCorruptedException: invalid stream header: 0176A800
at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:857)
at java.io.ObjectInputStream.<init>(ObjectInputStream.java:349)
at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:48)
at hudson.remoting.AbstractByteBufferCommandTransport.processCommand(AbstractByteBufferCommandTransport.java:201)
at hudson.remoting.AbstractByteBufferCommandTransport.receive(AbstractByteBufferCommandTransport.java:188)
at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onRead(ChannelApplicationLayer.java:186)
at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecv(ApplicationLayer.java:207)
at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecv(ProtocolStack.java:669)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processRead(SSLEngineFilterLayer.java:369)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecv(SSLEngineFilterLayer.java:117)
at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecv(ProtocolStack.java:669)
at org.jenkinsci.remoting.protocol.NetworkLayer.onRead(NetworkLayer.java:136)
at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:160)
at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:721)
Feb 06, 2018 8:23:38 PM hudson.model.AsyncPeriodicWork doRun
Feb 06, 2018 8:23:42 PM hudson.remoting.AbstractByteBufferCommandTransport processCommand
Attachments
Issue Links
- links to
Activity
Code changed in jenkins
User: Rebecca Ysteboe
Path:
src/main/java/hudson/remoting/AbstractByteArrayCommandTransport.java
src/main/java/hudson/remoting/AbstractByteBufferCommandTransport.java
http://jenkins-ci.org/commit/remoting/563bff81f5639db0aad501f784a97e8af6742541
Log:
Merge pull request #254 from rysteboe/JENKINS-49472
JENKINS-49472 Log channel name if command not constructed
Compare: https://github.com/jenkinsci/remoting/compare/8a22d34106ef...563bff81f563
Code changed in jenkins
User: Rebecca Ysteboe
Path:
src/main/java/hudson/remoting/AbstractByteArrayCommandTransport.java
src/main/java/hudson/remoting/AbstractByteBufferCommandTransport.java
http://jenkins-ci.org/commit/remoting/c9673314efaa10207c6ce02cf1cb1a7b2ed8b808
Log:
JENKINS-49472Log channel name if command not constructed