• Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • branch-api-plugin
    • None

      Currently the snippet generator suggests/generates:

      properties([[$class: 'JobPropertyImpl', throttle: [count: 1, durationName: 'hour', userBoost: true]]])
      

          [JENKINS-50561] Add @Symbol to "throttle builds" job properties

          Oleg Nenashev added a comment - It is Branch API Plugin: https://github.com/jenkinsci/branch-api-plugin/blob/920700e3a71da949c6c3cd1e30824a825fcc2be2/src/main/java/jenkins/branch/RateLimitBranchProperty.java

          Andrew Bayer added a comment -

          PR up at https://github.com/jenkinsci/branch-api-plugin/pull/127 adding the symbol rateLimitBuilds - I wanted to avoid having "throttle" in the symbol since it means something different here than it does over in Throttle Concurrent Builds.

          Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/branch-api-plugin/pull/127 adding the symbol rateLimitBuilds - I wanted to avoid having "throttle" in the symbol since it means something different here than it does over in Throttle Concurrent Builds.

          I have hit this today, the Directive Generator generates the following code that it is wrong

            options {
              rateLimitBuilds([count: 60, durationName: 'hour', userBoost: false])
            }
          

          it should be this one, notice that it missed adding the `throttle` part

            options {
              rateLimitBuilds(throttle: [count: 60, durationName: 'hour', userBoost: false])
            }
          

          Ivan Fernandez Calvo added a comment - I have hit this today, the Directive Generator generates the following code that it is wrong options { rateLimitBuilds([count: 60, durationName: 'hour' , userBoost: false ]) } it should be this one, notice that it missed adding the `throttle` part options { rateLimitBuilds(throttle: [count: 60, durationName: 'hour' , userBoost: false ]) }

          Liam Newman added a comment -

          ifernandezcalvo
          Does the generated code not work?

          Liam Newman added a comment - ifernandezcalvo Does the generated code not work?

          not at all

          Ivan Fernandez Calvo added a comment - not at all

          (I can confirm that it is not working and just silently ignored )

          Reinhold Füreder added a comment - (I can confirm that it is not working and just silently ignored )

            bitwiseman Liam Newman
            reinholdfuereder Reinhold Füreder
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: