Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51064

Lenient URL validator for Root URL

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      After the JENKINS-31661 introduction, Paul Milliken and Omar Kohl reported troubles with the too strict validation.

      We need to be more lenient especially with the TLDs.

        Attachments

          Issue Links

            Activity

            Hide
            dnusbaum Devin Nusbaum added a comment -

            Fixed in version 2.120, but there is a followup ticket JENKINS-51158 to address some further problems.

            Show
            dnusbaum Devin Nusbaum added a comment - Fixed in version 2.120 , but there is a followup ticket JENKINS-51158 to address some further problems.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Wadeck Follonier
            Path:
            core/src/main/java/jenkins/org/apache/commons/validator/routines/DomainValidator.java
            core/src/main/java/jenkins/util/UrlHelper.java
            core/src/test/java/jenkins/util/UrlHelperTest.java
            http://jenkins-ci.org/commit/jenkins/e7eec1cbe60067871689871f12a56d496abe60a2
            Log:
            JENKINS-51064 Lenient URL validator for Root URL (#3415)

            • especially with the TLDs
            • more test cases
            • add blank line
            • Adjust comment
            • Correction typo

            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/jenkins/org/apache/commons/validator/routines/DomainValidator.java core/src/main/java/jenkins/util/UrlHelper.java core/src/test/java/jenkins/util/UrlHelperTest.java http://jenkins-ci.org/commit/jenkins/e7eec1cbe60067871689871f12a56d496abe60a2 Log: JENKINS-51064 Lenient URL validator for Root URL (#3415) JENKINS-51064 Lenient URL validator for Root URL especially with the TLDs more test cases add blank line Adjust comment Correction typo * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I am calling it an issue taking the community rating feedback. It will require backporting to LTS if 2.119 is selected

            Show
            oleg_nenashev Oleg Nenashev added a comment - I am calling it an issue taking the community rating feedback. It will require backporting to LTS if 2.119 is selected

              People

              Assignee:
              wfollonier Wadeck Follonier
              Reporter:
              wfollonier Wadeck Follonier
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: